Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature-wisun] Added new start methods to Wi-SUN BR with WisunInterface parameter and deprecated the old ones #14462

Merged
merged 1 commit into from
Apr 14, 2021
Merged

Conversation

mikaleppanen
Copy link

Summary of changes

Previously WisunBorderRouter start() used NetworkInterface type for mesh interface, although only WisunInterface type is possible for the call. Added a new overloads of the start with the WisunInterface as mesh interface type and deprecated the old ones. This makes the calls stricter about the interface type and safer. It also allows to remove the reinterpret_cast that causes
compiler warning on ARM compiler.

Impact of changes

None

Migration actions required

None

Documentation

None


Pull request type

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[X] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@mikter @artokin


@ciarmcom
Copy link
Member

@mikaleppanen, thank you for your changes.
@artokin @mikter @ARMmbed/mbed-os-maintainers please review.

* \return MESH_ERROR_NONE on success.
* \return MESH_ERROR_UNKNOWN in case of failure.
* */
MBED_DEPRECATED_SINCE("mbed-os-5.15", "Using NetworkInterface type for mesh_if is deprecated, use WisunInterface instead")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the deprecated version to match the next Mbed OS 5.15 version, 5.15.8?.

…d deprecated the old ones

Previously WisunBorderRouter start() used NetworkInterface type for mesh interface, although only
WisunInterface type is possible for the call. Added a new overloads of the start with the
WisunInterface as mesh interface type and deprecated the old ones. This makes the calls stricter
about the interface type and safer. It also allows to remove the reinterpret_cast that causes
compiler warning on ARM compiler.
@mikaleppanen
Copy link
Author

Corrected mbed-os deprecation version and rebased over latest mbed-os

@mergify mergify bot added needs: CI and removed needs: review labels Apr 8, 2021
@0xc0170
Copy link
Contributor

0xc0170 commented Apr 8, 2021

CI started

@mbed-ci
Copy link

mbed-ci commented Apr 8, 2021

Test run: SUCCESS

Summary: 10 of 10 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 merged commit 1d1a8f9 into ARMmbed:feature-wisun Apr 14, 2021
@mergify mergify bot removed the ready for merge label Apr 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants