Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nuvoton: Fix hal_watchdog_kick() with WDT stopped #14555

Merged
merged 1 commit into from
Apr 30, 2021

Conversation

ccli8
Copy link
Contributor

@ccli8 ccli8 commented Apr 16, 2021

Summary of changes

This PR tries to fix watchdog_kick() which shall do nothing when WDT is stopped according to WDT HAL spec.

Change targets:

  • NUMAKER_PFM_NANO130
  • NUMAKER_PFM_M453
  • NUMAKER_PFM_NUC472
  • NUMAKER_PFM_M487/NUMAKER_IOT_M487

Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

According to HAL spec, hal_watchdog_kick() shall do nothing when WDT is stopped.
@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Apr 16, 2021
@ciarmcom
Copy link
Member

@ccli8, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@ccli8
Copy link
Contributor Author

ccli8 commented Apr 28, 2021

Update?

@mergify mergify bot added needs: CI and removed needs: review labels Apr 28, 2021
@0xc0170
Copy link
Contributor

0xc0170 commented Apr 28, 2021

CI started

@mbed-ci
Copy link

mbed-ci commented Apr 28, 2021

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_cmake-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

@0xc0170 0xc0170 merged commit 0a6f769 into ARMmbed:master Apr 30, 2021
@mergify mergify bot removed the ready for merge label Apr 30, 2021
@ccli8 ccli8 deleted the nuvoton_wdt_stop-n-kick branch May 4, 2021 01:08
@mbedmain mbedmain removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels May 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants