-
Notifications
You must be signed in to change notification settings - Fork 3k
lora driver-Added LR1110 driver in mbed-os #14560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
LoRa Driver for LR1110
@kvkc97, thank you for your changes. |
My aim is to integrate LR1110 Driver to mbed-os library and use the driver for LoRaWAN communication. I tried to add LR1110 as a library outside mbed-os and got few errors. Therefore, I tried to include LR1110 driver into mbed-os. I had tried to compile the library with mbed-os-example-lorawan code. Link of the same is given below. |
Did you declare |
No I have not defined them. I followed the format of SX1272 Radio object to declare the class and radio object for LR1110. The MBED_CONF_SX1272_ variables are not defined in the corresponding libraries. So I could not figure out where to define them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is specific driver to only one family of targets (stm32wb) ? This can't be made generic to be reused?
@ARMmbed/team-st-mcd Please review
#ifndef _CONFIGURATION_H | ||
#define _CONFIGURATION_H | ||
|
||
#include "stm32wbxx_ll_gpio.h" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this component only for stm32wbxx devices as it uses specific headers from the drivers ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I confirm :-)
no stm32xxx should be used I think...
MBED_CONF_xxx are set thanks to json lib configuration |
This pull request has automatically been marked as stale because it has had no recent activity. @kvkc97, please carry out any necessary work to get the changes merged. Thank you for your contributions. |
@kvkc97 What's the state of this, there is a merge commit (please rebase) ? |
The issue is not solved. I have created a latest repo in the below link. |
@kvkc97 I am closing this pull request as it has been stale for weeks. If you need any assistance, please use forum to ask questions or comment here with details. |
Summary of changes
LoRa Driver for LR1110 added for LoRaWAN communication with LR1110. Corresponding CMakeLists file modified.
This adds LR1110 as a lora driver along with current ones such as SX1276 etc.
Pull request type