Skip to content

lora driver-Added LR1110 driver in mbed-os #14560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from

Conversation

kvkc97
Copy link

@kvkc97 kvkc97 commented Apr 19, 2021

Summary of changes

LoRa Driver for LR1110 added for LoRaWAN communication with LR1110. Corresponding CMakeLists file modified.
This adds LR1110 as a lora driver along with current ones such as SX1276 etc.

Pull request type

[] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[X] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

@ciarmcom
Copy link
Member

@kvkc97, thank you for your changes.
@ARMmbed/mbed-os-connectivity @ARMmbed/mbed-os-maintainers please review.

@kvkc97
Copy link
Author

kvkc97 commented Apr 21, 2021

My aim is to integrate LR1110 Driver to mbed-os library and use the driver for LoRaWAN communication. I tried to add LR1110 as a library outside mbed-os and got few errors. Therefore, I tried to include LR1110 driver into mbed-os. I had tried to compile the library with mbed-os-example-lorawan code. Link of the same is given below.
https://github.com/ARMmbed/mbed-os-example-lorawan
I tried to create external radio for lr1110 by modifying the lora_radio_helper.cpp file as follows.
image
I also declared the class constructor in lr1110_radio.h from lr1110 driver folder as below.
image
I got the following compiler error. I am using MBED CLI2 for compiling with STM32WB55RGV6 controller added as custom target (Custom target addition is successfully done). I made the above mentioned changes to incorprate LR1110 as a lora driver. An issue regarding the same was raised in ARMmbed/mbed-tools. Link added below.
ARMmbed/mbed-tools#217
How should I proceed further. @ciarmcom @matthieuantoine
image

@matthieuantoine
Copy link

Did you declare MBED_CONF_lr1110_* constants somewhere in your code?

@kvkc97
Copy link
Author

kvkc97 commented Apr 22, 2021

No I have not defined them. I followed the format of SX1272 Radio object to declare the class and radio object for LR1110. The MBED_CONF_SX1272_ variables are not defined in the corresponding libraries. So I could not figure out where to define them.

Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is specific driver to only one family of targets (stm32wb) ? This can't be made generic to be reused?

@ARMmbed/team-st-mcd Please review

#ifndef _CONFIGURATION_H
#define _CONFIGURATION_H

#include "stm32wbxx_ll_gpio.h"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this component only for stm32wbxx devices as it uses specific headers from the drivers ?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirm :-)
no stm32xxx should be used I think...

@jeromecoutant
Copy link
Collaborator

No I have not defined them. I followed the format of SX1272 Radio object to declare the class and radio object for LR1110. The MBED_CONF_SX1272_ variables are not defined in the corresponding libraries. So I could not figure out where to define them.

MBED_CONF_xxx are set thanks to json lib configuration
and I couldn't see any json in your patch

@ciarmcom ciarmcom added the stale Stale Pull Request label May 10, 2021
@ciarmcom
Copy link
Member

This pull request has automatically been marked as stale because it has had no recent activity. @kvkc97, please carry out any necessary work to get the changes merged. Thank you for your contributions.

@ciarmcom ciarmcom added stale Stale Pull Request and removed stale Stale Pull Request labels May 14, 2021
@ciarmcom ciarmcom added stale Stale Pull Request and removed stale Stale Pull Request labels May 21, 2021
@ciarmcom ciarmcom added stale Stale Pull Request and removed stale Stale Pull Request labels May 28, 2021
@ciarmcom ciarmcom added stale Stale Pull Request and removed stale Stale Pull Request labels Jun 6, 2021
@ciarmcom ciarmcom added stale Stale Pull Request and removed stale Stale Pull Request labels Jun 18, 2021
@ciarmcom ciarmcom added stale Stale Pull Request and removed stale Stale Pull Request labels Jun 25, 2021
@ciarmcom ciarmcom removed the stale Stale Pull Request label Jul 1, 2021
@ciarmcom ciarmcom added stale Stale Pull Request and removed stale Stale Pull Request labels Jul 13, 2021
@0xc0170
Copy link
Contributor

0xc0170 commented Jul 20, 2021

@kvkc97 What's the state of this, there is a merge commit (please rebase) ?

@kvkc97
Copy link
Author

kvkc97 commented Jul 21, 2021

The issue is not solved. I have created a latest repo in the below link.
https://github.com/kvkc97/mbed-os-example-lorawan-lr1110
Since I could not attach the mbed-os library and the changes, i is attached in the below link.
https://github.com/kvkc97/mbed-os

@ciarmcom ciarmcom added stale Stale Pull Request and removed stale Stale Pull Request labels Jul 23, 2021
@0xc0170
Copy link
Contributor

0xc0170 commented Jul 28, 2021

@kvkc97 I am closing this pull request as it has been stale for weeks. If you need any assistance, please use forum to ask questions or comment here with details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants