Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake: Only force Ninja response files on Windows #14656

Merged
merged 1 commit into from
May 13, 2021

Commits on May 11, 2021

  1. CMake: Only force Ninja response files on Windows

    We force Ninja to create response files to work around file path length
    limitations on Windows. Previously we were forcing the response file
    generation for all platforms, unless we were building on Windows using
    ARMClang, this was to work around a CMake issue
    https://gitlab.kitware.com/cmake/cmake/-/issues/21093
    
    Unfortunately `ar` on macOS doesn't support Ninja response files. So the
    check was incorrect, as forcing a response file to be generated on macOS
    causes a build failure when trying to build Mbed's unit tests.
    
    This PR changes the logic so we only generate a response file on Windows
    systems if we're not building with ARMClang.
    rwalton-arm committed May 11, 2021
    Configuration menu
    Copy the full SHA
    ccb49b5 View commit details
    Browse the repository at this point in the history