Deprecate broken TDB_EXTERNAL_NO_RBP and FILESYSTEM_NO_RBP in kv_config #14657
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Replaces #14490: changed from removal to deprecation due to the Mbed OS release model.
NO_RBP (no rollback protection) is intended to not require an internal TDB, however, DeviceKey, which we use to derive SecureStore's encryption key, still does. Currently, no internal TDB is created with these two configurations, meaning there's no way to store the DeviceKey and SecureStore doesn't work. The configurations
TDB_EXTERNAL_NO_RBP
andFILESYSTEM_NO_RBP
are broken due to this design flaw.This PR deprecates the non-working configurations, with their documentations removed but code and configurations kept with deprecation warnings. They will be completely removed from the next major release.
Impact of changes
Existing applications that use
TDB_EXTERNAL_NO_RBP
andFILESYSTEM_NO_RBP
will still be able to compile for now, until we fully remove the two configurations in the future. But they have never been functional, so no application should have ever been able to use them.Migration actions required
Applications that have
storage.storage_type
set toTDB_EXTERNAL_NO_RBP
orFILESYSTEM_NO_RBP
should switch to useTDB_INTERNAL
,TDB_EXTERNAL
,FILESYSTEM
ordefault
depending on their use cases.Documentation
ARMmbed/mbed-os-5-docs#1440 raised to remove references to
TDB_EXTERNAL_NO_RBP
andFILESYSTEM_NO_RBP
from the online documentation.Pull request type
Test results
Reviewers
@ARMmbed/mbed-os-core