Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gate ticker (timer0) clock on deepsleep for MAX32620FTHR #14738

Merged
merged 1 commit into from
Jun 7, 2021

Conversation

ahmetalincak
Copy link

Summary of changes

Gate ticker clock on deepsleep to stop ticking. Fixes Greentea sleep tests for MAX32620FTHR.

Impact of changes

Migration actions required

Documentation


Pull request type

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

max32620fthr_greentea_test_log.log

[] No Tests required for this change (E.g docs only update)
[X] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@MarceloSalazar @0xc0170

@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Jun 6, 2021
@ciarmcom
Copy link
Member

ciarmcom commented Jun 6, 2021

@ahmetalincak, thank you for your changes.
@0xc0170 @MarceloSalazar @ARMmbed/mbed-os-maintainers please review.

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 7, 2021

Gate ticker clock on deepsleep to stop ticking. Fixes Greentea sleep tests for MAX32620FTHR.

What tests exactly were failing (which ones were red and are now green) ? I recall some issues related to this, was this reported earlier (should be referenced) ?

@mergify mergify bot added needs: CI and removed needs: review labels Jun 7, 2021
@0xc0170
Copy link
Contributor

0xc0170 commented Jun 7, 2021

Ci started

@mbed-ci
Copy link

mbed-ci commented Jun 7, 2021

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

@0xc0170 0xc0170 merged commit fef89d9 into ARMmbed:master Jun 7, 2021
@mergify mergify bot removed the ready for merge label Jun 7, 2021
@mbedmain mbedmain added release-version: 6.12.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Jun 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants