Update Cordio stack & LL to v21.04 #14798
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisswinchatt-arm
force-pushed
the
feature-cordio-21.04
branch
from
9db437a to
931ce84
Compare
ciarmcom
added
the
release-type: patch
|
@chrisswinchatt-arm, thank you for your changes. |
|
Is there a changelog? a list of bugs fixed or features added? The only packetcraft github repo lists a 19.x release and 20.04. There are no other branches. |
pan-
reviewed
Jun 18, 2021
connectivity/FEATURE_BLE/libraries/cordio_stack/ble-host/include/att_api.h
Show resolved
Hide resolved
connectivity/FEATURE_BLE/libraries/cordio_stack/ble-host/sources/hci/dual_chip/hci_evt.c
Outdated
Show resolved
Hide resolved
| * \return ATT_SUCCESS if successful or error code on failure. | ||
| */ | ||
| /*************************************************************************************************/ | ||
| static uint8_t attsSignedWritePermissions(dmConnId_t connId, uint16_t handle, uint8_t permissions, |
There was a problem hiding this comment.
I think we were doing these checks in our port. Can you verify if they are still needed in BLE API ?
| * | ||
| * \return None. | ||
| */ | ||
| /*************************************************************************************************/ | ||
| void DmSecSetLocalIdentityAddr(const uint8_t *pAddr, uint8_t type) | ||
| void DmSecSetLocalIdentityAddr(const bdAddr_t identityAddr, uint8_t addrType) |
There was a problem hiding this comment.
It's interresting that bdAddr is different from identity address now. This may have an impact with code in BLE API.
...ivers/ble/FEATURE_BLE/COMPONENT_CYW43XXX/firmware/COMPONENT_43012/w_bt_firmware_controller.c
Outdated
Show resolved
Hide resolved
...tivity/FEATURE_BLE/libraries/TARGET_CORDIO_LL/stack/controller/sources/common/chci/chci_tr.c
Outdated
Show resolved
Hide resolved
...tivity/FEATURE_BLE/libraries/TARGET_CORDIO_LL/stack/controller/sources/common/chci/chci_tr.c
Show resolved
Hide resolved
...tivity/FEATURE_BLE/libraries/TARGET_CORDIO_LL/stack/controller/sources/common/chci/chci_tr.c
Outdated
Show resolved
Hide resolved
Good point, we should always add changelog and release notes part of upstream updates. They will be added. |
chrisswinchatt-arm
force-pushed
the
feature-cordio-21.04
branch
from
931ce84 to
f6999bf
Compare
|
I have split the patch into separate commits for host, controller, drivers and integration, plus added the change logs and fixed some issues. |
chrisswinchatt-arm
force-pushed
the
feature-cordio-21.04
branch
3 times, most recently
from
e2f562b to
8a837e6
Compare
chrisswinchatt-arm
force-pushed
the
feature-cordio-21.04
branch
from
8a837e6 to
e850a06
Compare
chrisswinchatt-arm
force-pushed
the
feature-cordio-21.04
branch
from
e850a06 to
c2777b3
Compare
chrisswinchatt-arm
force-pushed
the
feature-cordio-21.04
branch
2 times, most recently
from
128fe63 to
9b92f4f
Compare
chrisswinchatt-arm
force-pushed
the
feature-cordio-21.04
branch
3 times, most recently
from
b864351 to
593c93b
Compare
chrisswinchatt-arm
changed the title
* Corrected use of NRF timers to match single-timer use in Cordio * Corrected use of NRF RTCs (RTC1 used directly in pal_timer.c and RTC2 used in pal_frc.c via NRFX API) * Add CordioHCIDriver::on_deep_sleep method which calls palFrcSetWakeup to wake the system from deep sleep, with wake latency compensation * Change mbed OS reserved RTC (COMMON_RTC_INSTANCE) to RTC0
chrisswinchatt-arm
force-pushed
the
feature-cordio-21.04
branch
from
593c93b to
54aeeb2
Compare
mergify
bot
removed
component: connectivity
component: security
needs: work
release-type: patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Updates the Cordio host stack, controller/link layer and Nordic drivers to version 21.04. Also adds a set of scripts to partially automate future updates.
Impact of changes
Migration actions required
Documentation
None
Pull request type
Test results
Reviewers
@ARMmbed/mbed-os-connectivity