Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

InterruptIn : STM32: Implemented error catching for multiple gpio on the same irq line #14843

Merged
merged 1 commit into from
Jul 8, 2021
Merged

InterruptIn : STM32: Implemented error catching for multiple gpio on the same irq line #14843

merged 1 commit into from
Jul 8, 2021

Conversation

AnishKumarHCL
Copy link
Contributor

@AnishKumarHCL AnishKumarHCL commented Jun 30, 2021 •
edited
Loading

Summary of changes

The multiple InterruptIn object with same pin_index sharing same IRQ line.
So the second object will overwrite the first one. To catch this as error,
implemented an error catching functionality.

Impact of changes

Migration actions required

Documentation

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@jeromecoutant

@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Jun 30, 2021
@ciarmcom ciarmcom requested review from jeromecoutant and a team June 30, 2021 14:30
@ciarmcom
Copy link
Member

@AnishKumarHCL, thank you for your changes.
@jeromecoutant @ARMmbed/mbed-os-maintainers please review.

@AnishKumarHCL
InterruptIn : STM32: Implemented error catching for multiple gpio irq…
91d0a6d 
… line

The multiple InterruptIn object with same pin_index sharing same IRQ line.
So the second object will overwrite the first one. To catch this as error,
implemented an error catching functionality.
jeromecoutant
jeromecoutant approved these changes Jul 2, 2021
View reviewed changes
Copy link
Collaborator

@jeromecoutant jeromecoutant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pilotak ref #14758

@pilotak
Copy link
Contributor

pilotak commented Jul 2, 2021

perfect


++ MbedOS Error Info ++
Error Status: 0x80FF0100 Code: 256 Module: 255
Error Message: Fatal Run-time error
Location: 0x8004263
Error Value: 0x0
Current Thread: main Id: 0x20000AC4 Entry: 0x8001A5D StackSize: 0x1000 StackMem: 0x20000E80 SP: 0x20001D7C
Next:
main  State: 0xhX Entry: 0x00000002 Stack Size: 0x08001A5D Mem: 0x00001000 SP: 0x20000E80
Ready:
rtx_idle  State: 0xhX Entry: 0x00000001 Stack Size: 0x08001B59 Mem: 0x00000200 SP: 0x20000858
Wait:
rtx_timer  State: 0xhX Entry: 0x00000083 Stack Size: 0x080018AD Mem: 0x00000300 SP: 0x20000558
Delay:
For more info, visit: https://mbed.com/s/error?error=0x80FF0100&tgt=NUCLEO_F091RC
-- MbedOS Error Info --
InterruptIn error: irq channel conflict

@jeromecoutant jeromecoutant mentioned this pull request Jul 2, 2021
Open
@0xc0170
Copy link
Contributor

0xc0170 commented Jul 8, 2021

CI started

@mergify mergify bot added needs: CI and removed needs: work labels Jul 8, 2021
@mbed-ci
Copy link

mbed-ci commented Jul 8, 2021

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

@0xc0170 0xc0170 merged commit f937383 into ARMmbed:master Jul 8, 2021
@mergify mergify bot removed the ready for merge label Jul 8, 2021
@artokin artokin mentioned this pull request Jul 12, 2021
Merged
@mbedmain mbedmain added release-version: 6.13.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@jeromecoutant jeromecoutant jeromecoutant approved these changes

Assignees
No one assigned
Labels
devices: st release-version: 6.13.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@AnishKumarHCL @ciarmcom @pilotak @0xc0170 @mbed-ci @jeromecoutant @mbedmain