Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add workflow for checking ble feature selection compilation #14927

Merged
merged 3 commits into from
Jul 20, 2021

Conversation

paul-szczepanek-arm
Copy link
Member

Summary of changes

This is a new workflow for github to add a new test in CI that checks BLE conditional compilation. Some BLE features can be toggled on or off, this makes sure it the project still compiles with different features toggled.

Impact of changes

Migration actions required

Documentation

none


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[x] Tests / results supplied as part of this PR

Reviewers


@paul-szczepanek-arm
Copy link
Member Author

Runs on my fork:
https://github.com/paul-szczepanek-arm/mbed-os/runs/3078802248?check_suite_focus=true
This currently fails because my PR with a fix hasn't been merged:
#14919

@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Jul 15, 2021
@ciarmcom ciarmcom requested a review from a team July 15, 2021 17:00
@ciarmcom
Copy link
Member

@paul-szczepanek-arm, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@pan-
Copy link
Member

pan- commented Jul 15, 2021

Maybe we can combine this with #14919 . After all this verifies that the conditional compilation has been fixed.

Copy link
Member

@pan- pan- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -0,0 +1,28 @@
name: run conditional BLE feature compilation
on:
workflow_dispatch:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so we can run it on BLE PRs.

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 16, 2021

Maybe we can run it for every PR that touches BLE: https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions#onpushpull_requestpaths .

This is still due (I don't see push attribute there)?

@paul-szczepanek-arm
Copy link
Member Author

OK, I changed it to run on each PR instead of weekly. It does run a dozen compiles but then again we're not paying for that :D

@mergify mergify bot added needs: CI and removed needs: review labels Jul 16, 2021
@ciarmcom ciarmcom added the stale Stale Pull Request label Jul 19, 2021
@ciarmcom
Copy link
Member

This pull request has automatically been marked as stale because it has had no recent activity. @ARMmbed/mbed-os-maintainers, please start CI to get the PR merged.

@0xc0170 0xc0170 removed the stale Stale Pull Request label Jul 19, 2021
@0xc0170
Copy link
Contributor

0xc0170 commented Jul 19, 2021

CI started

@0xc0170 0xc0170 merged commit 26889ca into ARMmbed:master Jul 20, 2021
@mergify mergify bot removed the ready for merge label Jul 20, 2021
@mbedmain mbedmain added release-version: 6.14.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants