Add ram and rom size config to targets.json (Copy mem reg info from index.json) #15094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rmation from index.json) ROM and RAM size is required in some of the greeentea tests to skip or include the test into the build, but when we copy the "mbed-rom-size", "mbed-ram-size" configs from index.json to targets.json causes the build failure for non-bootloader supported targets as MBED CLI1 expects that if any of the mem (ROM, RAM) configs are present in targets.json should have bootloader support, hence introducing new rom-size and ram-size using "config" in targets.json to generate MBED_CONF_TARGET_ROM_SIZE and MBED_CONF_TARGET_RAM_SIZE macros by Mbed CLI1 and Mbed CLI2 which can be used in the greentea test.
ciarmcom
added
the
release-type: patch
|
@rajkan01, thank you for your changes. |
jeromecoutant
suggested changes
Sep 21, 2021
There was a problem hiding this comment.
Lots of targets are missing ...?
You could also define this new config at "target" level at the beginning of the file,
and then avoid all these hep duplication lines ?
This is replacing #14975 ?
|
This pull request has automatically been marked as stale because it has had no recent activity. @Patater, @LDong-Arm, @rwalton-arm, @ARMmbed/mbed-os-maintainers, please complete review of the changes to move the PR forward. Thank you for your contributions. |
|
We are closing this pull request due to inactivity |
mergify
bot
removed
needs: review
release-type: patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
ROM and RAM size is required in some of the greeentea tests to skip or include the test into the build, but when we copy the
mbed_rom_size,mbed_ram_sizeconfigs fromindex.jsontotargets.jsoncauses the build failure for non-bootloader supported targets as MBED CLI1 expects that if any of the mem (ROM, RAM) configs are present in targets.json should have bootloader support, hence introducing newrom-sizeandram-sizeusingconfigin targets.json to generateMBED_CONF_TARGET_ROM_SIZEandMBED_CONF_TARGET_RAM_SIZEmacros by Mbed CLI1 and Mbed CLI2 which can be used in the greentea test.Impact of changes
None.
Migration actions required
Update the greentea test, which depends on MBED_RAM_SIZE and MBED_ROM_SIZE macros to replace with MBED_CONF_TARGET_ROM_SIZE and MBED_CONF_TARGET_RAM_SIZE.
Documentation
Pull request type
Test results
Reviewers