CMake: greentea: Migrate the NFC EEPROM test to CTest #15095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The most common extension for static libraries is .a and CMake generates
it with both GCC and Arm toolchains. Mbed CLI 1 generates .ar files with
the Arm Compiler, but since Mbed CLI 2 uses memap.py to generate map
files too, both extensions should be permitted.
This fixes a warning when building greentea tests:
Malformed input found when parsing ARMCC map: _deps/greentea-client-build/libclient_userio.a(greentea_test_env.o)
Malformed input found when parsing ARMCC map: _deps/greentea-client-build/libclient_userio.a(greentea_test_env.o)
Malformed input found when parsing ARMCC map: _deps/greentea-client-build/libclient_userio.a(greentea_test_env.o)
...
which repeats over 30 times per test.
Subdirectories should always be included in the CMake "all" target when building any tests, either unit tests or greentea tests.
When unit tests or unit test stubs get added as CMake targets, they becomes part of the "all" target and get compiled when building the whole project. When building greentea tests we need to disable unit tests and stubs to avoid unnecessary compilation and errors.
Greentea tests run on microcontrollers, so any required drivers need to be available and built. Note: Even though unit tests do not require drivers, for ease of maintenance there's no need to exclude those drivers when building unit tests because a driver only gets enabled when the Mbed target matches.
ciarmcom
added
the
release-type: patch
|
@LDong-Arm, thank you for your changes. |
rwalton-arm
approved these changes
Sep 21, 2021
|
This pull request has automatically been marked as stale because it has had no recent activity. @ARMmbed/mbed-os-maintainers, please start CI to get the PR merged. |
0xc0170
approved these changes
Sep 28, 2021
|
CI started |
Jenkins CI Test : ✔️ SUCCESSBuild Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
mbedmain
added
release-version: 6.15.1
Release-pending
and removed
release-type: patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Fixes #15093
We are migrating greentea tests from standalone CMake projects that use Mbed OS to executables within the Mbed OS CMake project. This has the benefit of building all greentea tests globally and using CTest to automate running on local and CI boards. This PR covers the NFC EEPROM test (the only NFC greentea test).
For example,
Impact of changes
Migration actions required
Documentation
None
Pull request type
Test results
Reviewers