STM32H7: increase i2c slave rx limit. #15212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciarmcom
added
the
release-type: patch
|
@mothacehe, thank you for your changes. |
jeromecoutant
approved these changes
Jan 28, 2022
0xc0170
previously approved these changes
Jan 28, 2022
|
CI started |
Jenkins CI Test : ✔️ SUCCESSBuild Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
Use uint16_t variables for i2c slave_rx_buffer_size and slave_rx_count variables. This allows to receive more than 255 bytes in slave mode. The bytes are received one by one in slave mode so there are no hardware limitations forcing a 1 byte rx count limit.
Thanks! Sure, I ported this change to all STM32 families. I can only test it on STM32H7 though. |
jeromecoutant
approved these changes
Jan 28, 2022
0xc0170
approved these changes
Jan 31, 2022
|
CI started |
Jenkins CI Test : ✔️ SUCCESSBuild Number: 2 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
mbedmain
added
release-version: 6.16.0
Release-pending
and removed
release-type: patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use uint16_t variables for i2c slave_rx_buffer_size and slave_rx_count
variables. This allows to receive more than 255 bytes in slave mode. The
bytes are received one by one in slave mode so there are no hardware
limitations forcing a 1 byte rx count limit.
Summary of changes
Allow I2CSlave::read method to operate on more than 255 bytes for STM32 H7 MCUs.
Impact of changes
Migration actions required
Documentation
None
Pull request type
Test results
On an STM32H743ZI2 Nucleo board, use the I2CSlave::read method to read 256 bytes correctly.
Reviewers