Add uVision4 exporters for DISCO-{F051R8, F100RB, F303VC, F407VG} #1522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(1) Add above exporters. (2) Modified only comments in "cmsis_nvic.h" files.
| @@ -873,6 +873,7 @@ def __init__(self): | |||
| self.extra_labels = ['STM', 'STM32F4', 'STM32F407', 'STM32F407VG'] | |||
| self.supported_toolchains = ["ARM", "uARM", "GCC_ARM"] | |||
| self.progen_target ='disco-f407vg' | |||
| self.default_toolchain = "uARM" | |||
There was a problem hiding this comment.
why are you setting uARM for 407?
|
@dinau This PR is looking fine. Just one thing, uARM for disco f407 does not make sense and should be changed to full ARM std library. Please have a look |
|
Hello 0xc0170, dinau |
|
Hi, Regards, |
| #define NVIC_NUM_VECTORS (16 + 100) | ||
| // MCU Peripherals: 61 vectors (= 244 bytes from 0x40 to 0x134) | ||
| // Total: 308 bytes to be reserved in RAM (see scatter file) | ||
| #define NVIC_NUM_VECTORS (16 + 61) |
There was a problem hiding this comment.
This should have been separate PR (at least own commit)
0xc0170
added a commit
that referenced
this pull request
Feb 11, 2016
Add uVision4 exporters for DISCO-{F051R8, F100RB, F303VC, F407VG}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(1) Add above exporters.
(2) Modified only comments in "cmsis_nvic.h" files.