Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

semihosting: Fix typo in semihost_rename #15271

Merged
merged 1 commit into from
Apr 26, 2022
Merged

Conversation

caspermeijn
Copy link
Contributor

Summary of changes

Fix typo in semihost_rename. Now it actually sends the new_name as well as the old_name.

Impact of changes

Migration actions required

Documentation

None


Pull request type

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

This fix is includes in a downstream: Apache Mynewt

[] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers


@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Apr 19, 2022
@ciarmcom ciarmcom requested a review from a team April 19, 2022 20:00
@ciarmcom
Copy link
Member

@caspermeijn, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

0xc0170
0xc0170 previously approved these changes Apr 20, 2022
@0xc0170
Copy link
Contributor

0xc0170 commented Apr 20, 2022

we are having issues with github actions due to recent git update, they will fail here. Once we make it green again, we will get back here with an update

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 20, 2022

Github actions fix #15270 was merged, please rebase and it should be green

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 25, 2022

Please rebase to the latest master

Fix typo in semihost_rename. Now it actually sends the `new_name` as well as the `old_name`.
@0xc0170
Copy link
Contributor

0xc0170 commented Apr 26, 2022

CI started

@mergify mergify bot added needs: CI and removed needs: review labels Apr 26, 2022
@mbed-ci
Copy link

mbed-ci commented Apr 26, 2022

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

@0xc0170 0xc0170 merged commit 9f326aa into ARMmbed:master Apr 26, 2022
@mergify mergify bot removed the ready for merge label Apr 26, 2022
@caspermeijn caspermeijn deleted the patch-1 branch April 29, 2022 21:31
@mbedmain mbedmain added release-version: 6.16.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants