-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for Compiler warnings #1532
Closed
Closed
Changes from 3 commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
2ae8c77
dont track commit venv directory
sg- b01d3c9
add notes to readme
sg- 6da4190
[STM B96B_F446VE] HW Control Flow for serial
adustm 6e45daf
Add uVision4 exporters for DISCO-{F051R8, F100RB, F303VC, F407VG}
dinau 2ce7eab
add mbed os defines to mbed targets
sg- 715fca0
add extra mbed identifier. correct duplicate target
sg- 9f28c09
Readme - update ides, add note about progen replacement
0xc0170 44b9db6
Merge branch 'master' of https://github.com/mbedmicro/mbed into perip…
88c05ca
Fix for compiler warnings
22b8abc
Fixed build error
1b8d317
Merge pull request #1527 from 0xc0170/fix_ide
0xc0170 66c0620
Merge pull request #1521 from adustm/b_b96b_serial_flow_control
0xc0170 1b8f2c7
[DISCO-F407VG]:Changed: Default toolchain from uARM to ARM.
dinau c301abb
Merge pull request #1522 from dinau/disco-uvision4-exporter
0xc0170 c9cd05f
[sw4stm32] Fix compilation issue while exporting project using onlin…
DanKupiniak 91fae56
Update Teensy3_1 OS_CLOCK
star297 1c53fe8
Update README.md
sg- 066dc77
Merge pull request #1539 from DanKupiniak/fix_sw4stm32
0xc0170 333bfa2
Merge pull request #1540 from star297/master
0xc0170 9e41fec
Merge pull request #1541 from sg-/venv
0xc0170 05e8585
Merge pull request #1526 from sg-/mbedos-macros
0xc0170 8abc70e
Fix SAML21J18A.sct
9dcb51c
Merge branch 'maclobdell-patch-1'
0xc0170 934a326
Fixed style and build issue
a736139
Merge branch 'master' of https://github.com/mbedmicro/mbed into perip…
d578a72
Fix for compiler warnings
86b8516
Fixed build error
a8e52a9
Fixed style and build issue
6102a64
Merge branch 'master' of https://github.com/Parthasarathy/mbed
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -487,40 +487,30 @@ enum status_code system_clock_source_write_calibration( | |
{ | ||
switch (clock_source) { | ||
case SYSTEM_CLOCK_SOURCE_OSC8M: | ||
|
||
if (calibration_value > 0xfff || freq_range > 4) { | ||
return STATUS_ERR_INVALID_ARG; | ||
} | ||
|
||
if (calibration_value > 0xfff || freq_range > 4) | ||
{ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Wrong alignment of { |
||
return STATUS_ERR_INVALID_ARG; | ||
} | ||
SYSCTRL->OSC8M.bit.CALIB = calibration_value; | ||
SYSCTRL->OSC8M.bit.FRANGE = freq_range; | ||
break; | ||
|
||
case SYSTEM_CLOCK_SOURCE_OSC32K: | ||
|
||
if (calibration_value > 128) { | ||
return STATUS_ERR_INVALID_ARG; | ||
} | ||
|
||
_system_osc32k_wait_for_sync(); | ||
SYSCTRL->OSC32K.bit.CALIB = calibration_value; | ||
break; | ||
|
||
case SYSTEM_CLOCK_SOURCE_ULP32K: | ||
|
||
if (calibration_value > 32) { | ||
return STATUS_ERR_INVALID_ARG; | ||
} | ||
|
||
SYSCTRL->OSCULP32K.bit.CALIB = calibration_value; | ||
break; | ||
|
||
default: | ||
Assert(false); | ||
return STATUS_ERR_INVALID_ARG; | ||
break; | ||
} | ||
|
||
} | ||
return STATUS_OK; | ||
} | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -45,6 +45,7 @@ | |
*/ | ||
|
||
#include <system.h> | ||
#include <toolchain.h> | ||
|
||
/** | ||
* \internal | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -103,4 +103,4 @@ void pin_mode(PinName pin, PinMode mode) | |
} | ||
|
||
system_pinmux_pin_set_config(pin, &pin_conf); | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you using tabs here? Formatting seems to be wrong