Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incoming DLC len fix #15364

Closed
wants to merge 0 commits into from
Closed

Incoming DLC len fix #15364

wants to merge 0 commits into from

Conversation

Martyx00
Copy link
Contributor

@Martyx00 Martyx00 commented Jan 3, 2023

Summary of changes

Change on how the incoming CAN message DLC field is processed by the STM HAL. Previously, any value up to 0xF was allowed. The updated code limits this to value maximum of 8. Values higher than 8 are only used in CANFD which is not affected by this code change.

Impact of changes

CAN message DLC value can no longer be higher than 8 in standard CAN mode.

Migration actions required

None

Documentation

None


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers


0xc0170
0xc0170 previously approved these changes Jan 3, 2023
@0xc0170 0xc0170 added needs: CI release-type: patch Indentifies a PR as containing just a patch labels Jan 3, 2023
@jeromecoutant
Copy link
Collaborator

I suppose it fixes #15361 ?

@Martyx00
Copy link
Contributor Author

Martyx00 commented Jan 3, 2023

I suppose it fixes #15361 ?

Yes

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 5, 2023

CI started

@mbed-ci
Copy link

mbed-ci commented Jan 5, 2023

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 5, 2023

@Martyx00 I've missed failing license. Can you rebase to the latest master branch - it should fix it.

@mergify mergify bot dismissed 0xc0170’s stale review January 6, 2023 06:21

Pull request has been modified.

@Martyx00
Copy link
Contributor Author

Martyx00 commented Jan 6, 2023

Should be done now.

@Martyx00 Martyx00 requested a review from 0xc0170 January 10, 2023 11:10
@0xc0170
Copy link
Contributor

0xc0170 commented Jan 16, 2023

@Martyx00 I was away the last days. sorry for the delay.

Can you rebase please instead of merging ? To keep the history linear. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants