Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mesh connect semaphore not releasing causing blockage #15367

Merged
merged 1 commit into from
Jan 5, 2023

Conversation

YannCharbon
Copy link
Contributor

Summary of changes

When MeshInterface::disconnect() is called after MeshInterface::connect() has been called but before the Wi-SUN connection process has ended, there is a deadlock situation which prevents restarting the connection process. This is due to the fact that the connection semaphore is only released when the interface reaches a "CONNECTED" state.

This PR fixes this deadlock by releasing the connection semaphore if MeshInterface::disconnect() is invoked.

Impact of changes

Migration actions required

Documentation


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers


@YannCharbon
Copy link
Contributor Author

@0xc0170 I recreated this PR and #15366 because I had some troubles on my side. I took the opportunity to fix the dependency issue between the two PRs, so everything should be alright now. Excuse me for the inconvenience.

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 5, 2023

CI started

@mergify mergify bot added the needs: CI label Jan 5, 2023
@mbed-ci
Copy link

mbed-ci commented Jan 5, 2023

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants