Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't overlap STM32 FDCAN RAM sections #15472

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

jtmyz9
Copy link

@jtmyz9 jtmyz9 commented Nov 30, 2023

Summary of changes

Shift Inital RAM Offset by index * large Number of words so that if multiple FDCAN instances created for multiple channels on STM32H7 chips they are not all pointing to the exact same CAN RAM section and sharing FIFO, filters, TX buffers, etc.

Current implementation leaves ALL FDCAN peripherals pointing to same segment of the RAM section allocated for CAN, thus messages from all the different "busses" will get pushed into same FIFO. Change makes it such that each FDCAN object actually has independent FIFOs and filters. This is acceptable because we are allocating significantly less than maximum RAM size for each instance ~306 words of maximum 2560 words

Impact of changes

Migration actions required

Documentation


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers


@jtmyz9
Copy link
Author

jtmyz9 commented Dec 4, 2023

Who do I need to poke to get an approving review on this PR? Would be great to get this merged 🥺

@jeromecoutant
Copy link
Collaborator

Who do I need to poke to get an approving review on this PR? Would be great to get this merged 🥺

@0xc0170 :-)

@0xc0170 0xc0170 added needs: CI release-type: patch Indentifies a PR as containing just a patch labels Dec 8, 2023
@jtmyz9
Copy link
Author

jtmyz9 commented Dec 12, 2023

Now I just need to bribe someone to run ci and merge it? 😉

@0xc0170
Copy link
Contributor

0xc0170 commented Dec 14, 2023

I've missed to trigger CI, fixing now.

CI started

@mbed-ci
Copy link

mbed-ci commented Dec 14, 2023

Jenkins CI Test : ❌ FAILED

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test

@mergify mergify bot added needs: work and removed needs: CI labels Dec 14, 2023
@0xc0170
Copy link
Contributor

0xc0170 commented Dec 14, 2023

CI restarted

@mbed-ci
Copy link

mbed-ci commented Dec 14, 2023

Jenkins CI Test : ❌ FAILED

Build Number: 2 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test

@mergify mergify bot added needs: work and removed needs: CI labels Dec 14, 2023
@jtmyz9
Copy link
Author

jtmyz9 commented Dec 18, 2023

The CI failure looks like something unrelated to this change?

@0xc0170 0xc0170 merged commit 61ab4f7 into ARMmbed:master Dec 19, 2023
11 checks passed
@mergify mergify bot removed the ready for merge label Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-type: patch Indentifies a PR as containing just a patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants