-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't overlap STM32 FDCAN RAM sections #15472
Merged
0xc0170
merged 1 commit into
ARMmbed:master
from
jtmyz9:jmcloud/STM32-use-more-than-one-fifo
Dec 19, 2023
Merged
Don't overlap STM32 FDCAN RAM sections #15472
0xc0170
merged 1 commit into
ARMmbed:master
from
jtmyz9:jmcloud/STM32-use-more-than-one-fifo
Dec 19, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeromecoutant
approved these changes
Dec 1, 2023
Who do I need to poke to get an |
@0xc0170 :-) |
0xc0170
approved these changes
Dec 8, 2023
0xc0170
added
needs: CI
release-type: patch
Indentifies a PR as containing just a patch
labels
Dec 8, 2023
Now I just need to bribe someone to run ci and merge it? 😉 |
I've missed to trigger CI, fixing now. CI started |
Jenkins CI Test : ❌ FAILEDBuild Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
CI restarted |
Jenkins CI Test : ❌ FAILEDBuild Number: 2 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
The CI failure looks like something unrelated to this change? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Shift Inital RAM Offset by index * large Number of words so that if multiple FDCAN instances created for multiple channels on STM32H7 chips they are not all pointing to the exact same CAN RAM section and sharing FIFO, filters, TX buffers, etc.
Current implementation leaves ALL FDCAN peripherals pointing to same segment of the RAM section allocated for CAN, thus messages from all the different "busses" will get pushed into same FIFO. Change makes it such that each FDCAN object actually has independent FIFOs and filters. This is acceptable because we are allocating significantly less than maximum RAM size for each instance ~306 words of maximum 2560 words
Impact of changes
Migration actions required
Documentation
Pull request type
Test results
Reviewers