Corrected virtualenv-related instructions in README.md #1900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. +1 and thanks! |
|
Just tried the instructions and it seems that the old instructions were for Windows. Do you think both instructions can be provided? |
|
Any update to make it for win/unix as requested above? |
|
I am closing this PR, I'll create an issue to fix the instructions (multiplatform). |
artokin
pushed a commit
to artokin/mbed-os
that referenced
this pull request
Nov 10, 2018
…..513a38e 513a38e Merge branch 'release_internal' into release_external 3d2f391 Use Mbed OS coding style (ARMmbed#1900) e07cfb4 re-factored thread_mcast_should_register_address. (ARMmbed#1887) 426acd1 Fixed filter to not drop packets when no modification git-subtree-dir: features/nanostack/sal-stack-nanostack git-subtree-split: 513a38e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to follow the setup instructions in README.md but discovered that they didn't work because they referred to the non-existent venv/Scripts directory, and didn't properly source the correct file. This PR fixes those instructions.