uvision - remove --cpp flag from exporters #1933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The cpp files are by default compiled with --cpp. Including this flag, causing C files compiled as C++ files. Thus we remove them. We could potentionally remove it from cxx flags as well.
|
cc @stevew817 |
ohagendorf
added a commit
to ohagendorf/mbed-os
that referenced
this pull request
Jun 14, 2016
- one missing import - typo: uvision instead of uvision5 used
|
It works but there are some minor fixes necessary. Please see PR #1935 |
0xc0170
added a commit
that referenced
this pull request
Jun 14, 2016
[uviosn5] some fixes for PR #1933
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cpp files are by default compiled with --cpp. Including this flag, causing
C files compiled as C++ files. Thus we remove them. We could potentionally
remove it from cxx flags as well.
This was added just recently as flags unification. It's tricky to unify command line and IDE, as via cmd you can invoke separately asm/c/cxx, but in many IDE c/cxx are within the same tab. Therefore there are some limitations and we need to currently do exceptions for IDE, as in this PR.
Fixes #1919
@ohagendorf