Skip to content

Fix iar exporter - flags duplication and consolidations #1938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 14, 2016

Conversation

0xc0170
Copy link
Contributor

@0xc0170 0xc0170 commented Jun 14, 2016

We need to distinguish between cmd flags and exporters flags, they are not the same.

cc @theotherjimmy

0xc0170 added 2 commits June 14, 2016 14:37
- vla flag is not compatible with c++ (not supported), it generates an error
in the IDE. Therefore we remove it
- common flags - add dlib and thum to the common flags.
- cpu flag is for only runtime cmd, IDE sets it via defined MCU, not required.
@theotherjimmy
Copy link
Contributor

I don't like that we have to remove the cpu from the common flags specifically in the exporter, but I understand the reasoning.

@theotherjimmy
Copy link
Contributor

👍

@0xc0170 0xc0170 merged commit cfa4d0c into ARMmbed:master Jun 14, 2016
@sg-
Copy link
Contributor

sg- commented Jun 14, 2016

If you make a change to IAR we MUST run tests against IAR. This is a breaking change.

@0xc0170
Copy link
Contributor Author

0xc0170 commented Jun 15, 2016

If you make a change to IAR we MUST run tests against IAR. This is a breaking change.

The only breaking change in here could be VLA, and that dlib config? I run local tests, did not spot any regession, I'll rebase this fix, and rerun the bot

This is a breaking change.

Please provide more details

@bogdanm
Copy link
Contributor

bogdanm commented Jun 15, 2016

If you make a change to IAR we MUST run tests against IAR. This is a breaking change.

+1. Removing --vla is likely to break some user code.

@0xc0170
Copy link
Contributor Author

0xc0170 commented Jun 15, 2016

+1. Removing --vla is likely to break some user code.

No it's should not. It was fixed today (--vla was removed) today anyway. This flag was introduced 1 week ago, since then IAR exporters were not much functional (difference in flags, and their consolidation). The vla addition broke the exporters (IAR does not support --c++ and --vla). thus if we use C++, VLA must be disabled (produces error invalid combination --vla and --c++) - this is valid for project files, cmd has different rules

@bogdanm
Copy link
Contributor

bogdanm commented Jun 15, 2016

this is valid for project files, cmd has different rules

I see, thank you, I wasn't aware of this restriction. It looks like this isn't as risky as I thought it would be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants