Skip to content

Use nano lib by default for nrf51 based targets. #2025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 28, 2016

Conversation

pan-
Copy link
Member

@pan- pan- commented Jun 27, 2016

By default, default_build is set to standard for all targets.

NRF51 is very a very constrained platform, it makes a lot of sense to set default_build to small for all NRF51 based targets.

@pan-
Copy link
Member Author

pan- commented Jun 27, 2016

@0xc0170

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 27, 2016

LGTM

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 27, 2016

@mbed-bot: TEST

HOST_OSES=windows
BUILD_TOOLCHAINS=GCC_ARM,IAR,ARM,uARM
TARGETS=NRF51_DK,NRF51_MICROBIT

@mbed-bot
Copy link

[Build 534]
FAILURE: Something went wrong when building and testing.

@bridadan
Copy link
Contributor

There was an issue with singletest.py that was caught by this PR. It only affects targets that have a custom program_cycle_s attribute set in targets.json. There is a pending fix open here: #2032.

After that fix is merged, please re run the bot.

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 28, 2016

@mbed-bot: TEST

HOST_OSES=windows
BUILD_TOOLCHAINS=GCC_ARM,IAR,ARM,uARM
TARGETS=NRF51_DK,NRF51_MICROBIT

@mbed-bot
Copy link

[Build 549]
SUCCESS: Building succeeded and tests were run! Be sure to check the test results

@0xc0170 0xc0170 removed the needs: CI label Jun 28, 2016
@0xc0170 0xc0170 merged commit 05b8db4 into ARMmbed:master Jun 28, 2016
@pan- pan- deleted the nrf51_nano branch September 27, 2016 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants