Marked thread-spawning constructors as deprecated #2055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thread-spawning constructors hide errors and may lead to complex program state when a thread is declared. The explicit Thread::start member function should be used to spawn a thread.
|
Looks good. Is there any link to our deprecation policy ? |
Fair point, not yet. I would suggest stating explicitly in the message for how long it stays deprecated (removed by x.x.x release) - to track the lifetime of deprecated attributes. |
|
LGTM Let's not forget to state this deprecate msg in the release notes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thread-spawning constructors hide errors and may lead to complex program state when a thread is declared.
The explicit Thread::start member function should be used to spawn a thread.
More info:
#79
#2024
cc @pan-, @niklas-arm, @0xc0170