Skip to content

Add MBED_A27 test in the common list #2149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 12, 2016
Merged

Add MBED_A27 test in the common list #2149

merged 2 commits into from
Aug 12, 2016

Conversation

jeromecoutant
Copy link
Collaborator

MBED_A27 test doesn't need any peripheral
it can then be added in the common list

@jeromecoutant
Copy link
Collaborator Author

Tested with STM32:

+--------+---------------------+-----------+----------+-------------------+--------------------+---------------+-------+
| Result | Target | Toolchain | Test ID | Test Description | Elapsed Time (sec) | Timeout (sec) | Loops |
+--------+---------------------+-----------+----------+-------------------+--------------------+---------------+-------+
| OK | NUCLEO_F091RC[E34D] | ARM | MBED_A27 | CAN loopback test | 10.5 | 20 | 1/1 |
| OK | NUCLEO_F042K6[E1AD] | ARM | MBED_A27 | CAN loopback test | 10.55 | 20 | 1/1 |
| OK | NUCLEO_F072RB[FE35] | ARM | MBED_A27 | CAN loopback test | 10.52 | 20 | 1/1 |
| OK | DISCO_F746NG[F131] | ARM | MBED_A27 | CAN loopback test | 10.51 | 20 | 1/1 |
| OK | NUCLEO_F746ZG[F92A] | ARM | MBED_A27 | CAN loopback test | 10.52 | 20 | 1/1 |
| OK | DISCO_L476VG[FD1D] | ARM | MBED_A27 | CAN loopback test | 10.75 | 20 | 1/1 |
| OK | NUCLEO_L476RG[F342] | ARM | MBED_A27 | CAN loopback test | 10.73 | 20 | 1/1 |
| OK | NUCLEO_F303K8[E06B] | ARM | MBED_A27 | CAN loopback test | 10.56 | 20 | 1/1 |
| OK | NUCLEO_F302R8[F03C] | ARM | MBED_A27 | CAN loopback test | 10.38 | 20 | 1/1 |
| OK | NUCLEO_F334R8[E712] | ARM | MBED_A27 | CAN loopback test | 10.34 | 20 | 1/1 |
| OK | NUCLEO_F303RE[7252] | ARM | MBED_A27 | CAN loopback test | 10.39 | 20 | 1/1 |

@LMESTM
Copy link
Contributor

LMESTM commented Jul 12, 2016

I actually did test the same - so : LGTM

@PrzemekWirkus
Copy link
Contributor

+1

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 13, 2016

@mbed-bot: TEST

HOST_OSES=windows
BUILD_TOOLCHAINS=ALL
TARGETS=ALL

@mbed-bot
Copy link

[Build 620]
FAILURE: Something went wrong when building and testing.

@bridadan
Copy link
Contributor

It still needs an external wire to do the loopback, correct? Hasn't this requirement been historically captured by a "peripheral" @PrzemekWirkus ?

@devanlai
Copy link
Contributor

Some CAN controllers have an internal loopback, but not all of them. I originally wasn't going to include a peripheral requirement, but IIRC, the LPC1768 requires a real transceiver to do the loopback.

It definitely needs to be run against other CAN controllers - the LPC1549 and LPC1768 each have different CAN peripherals that need to be tested.

@PrzemekWirkus
Copy link
Contributor

@bridadan Right, it is not all exclusive feature because not all controllers have circuitry as it was pointed out.

Option: Have two CAN loopback tests, one to use no-wire/internal circuitry without peripheral flag. This one would be limited with "mcu" tag to support subset of platforms which have proper peripheral feature on board.
Second test with explicit "peripheral" tag and pinology required for hard-wiring.

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 21, 2016

@bridadan @PrzemekWirkus is this PR correct or not? Based on the comments above, I would say it's not.

@PrzemekWirkus
Copy link
Contributor

@0xc0170 It is NOT.

@jeromecoutant
Create MBED_A28 test in the common list
463c7d2 
MBED_A28 test is the same as MBED_A27 test.
This is a CAN loopback test without any peripheral or wire.
It can then be added in the common list.
@jeromecoutant
Copy link
Collaborator Author

Hi
I then kept MBED_A27 CAN loopback test as it is (so with peripheral flag),
and created MBED_A28, which is the same test case, without peripheral flag.

@bridadan
Copy link
Contributor

@jeromecoutant thanks for looking at this. Just to confirm, do all of the targets listed in the mcu field have an internal CAN loopback?

@jeromecoutant
Copy link
Collaborator Author

Hi

Here is test results for all listed targets:

| OK | NUCLEO_F091RC[E34D] | GCC_ARM | MBED_A28 | CAN loopback test | 10.5 | 20 | 1/1 |
| OK | NUCLEO_F042K6[E1AD] | GCC_ARM | MBED_A28 | CAN loopback test | 10.55 | 20 | 1/1 |
| OK | NUCLEO_F072RB[FE35] | GCC_ARM | MBED_A28 | CAN loopback test | 10.51 | 20 | 1/1 |
| OK | NUCLEO_F103RB[0527] | GCC_ARM | MBED_A28 | CAN loopback test | 10.45 | 20 | 1/1 |
| OK | NUCLEO_F207ZG[F014] | GCC_ARM | MBED_A28 | CAN loopback test | 10.4 | 20 | 1/1 |
| OK | NUCLEO_F303K8[E06B] | GCC_ARM | MBED_A28 | CAN loopback test | 10.52 | 20 | 1/1 |
| OK | NUCLEO_F302R8[F03C] | GCC_ARM | MBED_A28 | CAN loopback test | 10.51 | 20 | 1/1 |
| OK | NUCLEO_F334R8[E712] | GCC_ARM | MBED_A28 | CAN loopback test | 10.55 | 20 | 1/1 |
| OK | NUCLEO_F303RE[7252] | GCC_ARM | MBED_A28 | CAN loopback test | 10.5 | 20 | 1/1 |
| OK | DISCO_F469NI[F7B1] | GCC_ARM | MBED_A28 | CAN loopback test | 10.58 | 20 | 1/1 |
| OK | NUCLEO_F446ZE[F130] | GCC_ARM | MBED_A28 | CAN loopback test | 10.51 | 20 | 1/1 |
| OK | NUCLEO_F446RE[F048] | GCC_ARM | MBED_A28 | CAN loopback test | 10.55 | 20 | 1/1 |
| OK | DISCO_F429ZI[F0A3] | GCC_ARM | MBED_A28 | CAN loopback test | 10.56 | 20 | 1/1 |
| OK | DISCO_F746NG[F131] | GCC_ARM | MBED_A28 | CAN loopback test | 10.55 | 20 | 1/1 |
| OK | NUCLEO_F746ZG[F92A] | GCC_ARM | MBED_A28 | CAN loopback test | 10.52 | 20 | 1/1 |
| OK | DISCO_L476VG[FD1D] | GCC_ARM | MBED_A28 | CAN loopback test | 10.63 | 20 | 1/1 |
| OK | NUCLEO_L476RG[F342] | GCC_ARM | MBED_A28 | CAN loopback test | 10.76 | 20 | 1/1 |

@bridadan
Copy link
Contributor

@mbed-bot: TEST

HOST_OSES=windows
BUILD_TOOLCHAINS=ARM,IAR,GCC_ARM
TARGETS=HEXIWEAR,K64F,NRF51_DK,NRF51_MICROBIT,NUCLEO_F411RE

@mbed-bot
Copy link

[Build 804]
SUCCESS: Building succeeded and tests were run! Be sure to check the test results

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 12, 2016 •
edited
Loading

LGTM

Tests OK

@0xc0170 0xc0170 merged commit 3d61535 into ARMmbed:master Aug 12, 2016
@jeromecoutant jeromecoutant deleted the PR_MBED_A27 branch August 16, 2016 07:44
JarkkoPaso pushed a commit to JarkkoPaso/mbed-os that referenced this pull request Aug 26, 2019
Squashed 'features/nanostack/sal-stack-nanostack/' changes from 3c7d50e…
b791093 
…..4a19dc4

4a19dc4 Import new thread files
f6a021d Removed test files
b9e842a Merge branch 'release_internal' into release_external
7d5d869 Merge pull request ARMmbed#2167 from ARMmbed/release_internal_merge
26e2d43 Merge branch 'master' into release_internal
f43620f Add support for India band (ARMmbed#2166)
122f158 Merge pull request ARMmbed#2165 from ARMmbed/release_internal_merge
0e65ee5 Added disabling of NA for Thread BR PPP backbone
4c50e52 Added disabling of NA for Wi-SUN BR PPP backbone
d2ea325 Moved DAD enabled check to Ipv6 SLAAC handler
49994fc Added PPP interface to nanostack
3383e91 Merge pull request ARMmbed#2163 from ARMmbed/IOTTHD-3558
81f7511 MAC: print RF configs
397240a MAC: Implemented CCA threshold and TX power setting
5907042 Added check for allocation failures in EAPOL
9ed97c9 ETX update:
b489415 Add own certificate handling APIS (ARMmbed#2149)
888a0fb fhss_ws: check if 0 used as divider
586f2f2 Merge pull request ARMmbed#2160 from hugueskamba/hk-iotcore-1299-remove-fp-usage-ns_monitor
f1d03b1 Remove floating-point usage in Nanostack heap monitor
ef88f64 Removed rank comprae and also probe 5 best on the list.
a2887d6 Clean PAN id compare trace print.
f37dcf2 Wi-SUN NS NUD & Probe send update
f7133f8 Merge pull request ARMmbed#2158 from ARMmbed/remove_temp_debug_traces
2dc1a8e fhss_ws: removed temporary debug traces
96f962a Reduce wi-sun NS Probe
0a1beb2 GTK update trigger fix
a1d172e Limit Pan config sol timeout after 5 solication.
9d7414b Limit PAE supplikant GTK re-use for authentication from 2->1.
662df08 Fixed Key request address set issue if GTK mismatch is detected.
a56b908 Merge pull request ARMmbed#2153 from ARMmbed/IOTTHD-3650
9b33e98 Fixed mac_pd_sap CCA_PREPARE active ACK handler.
035af9a Enhanced ACK GEN and TX update
b1beb5d fhss_ws: typecast drift to int32_t
f786fc9 Merge pull request ARMmbed#2152 from ARMmbed/fhss_coverity_fix
6efff35 fhss_ws: Coverity fixes
d743e91 WS LLC brodacst shedule fix
6a6fb0c Removed old configuration options from Border router API
a051865 Merge pull request ARMmbed#2135 from ARMmbed/IOTTHD-3232
ff771b1 Added empty interface function for network name set
e94da3c Merge pull request ARMmbed#2146 from ARMmbed/IOTTHD-3571_2
234e649 added network name change function to public API
1770465 fhss_ws: Added temporary debug traces (IOTTHD-3571)
d400859 Fix Thread 1.1 unitests (ARMmbed#2145)
38978f3 wi-sun ETX update:
4a71b04 Adjust Thread functions defined for Thread 1.2 (ARMmbed#2139)
4d8dc0d remove border router from pan size calculation
fb3363e Merge pull request ARMmbed#2141 from ARMmbed/IOTTHD-3571
f01c5f2 fhss_ws: conversion macros/functions to support int64
a7b0027 Suprress dio sending whenRPL is not yet ready
f8c9d54 Adjust tracing (ARMmbed#2138)
678eaf8 Moved Thread 1.2 code to to correct place
f39d07e Merge pull request ARMmbed#2136 from ARMmbed/IOTTHD-3571
ab23116 FHSS: temporary debug traces (IOTTHD-3571)
09d4b06 MAC: Implemented PHY statistics

git-subtree-dir: features/nanostack/sal-stack-nanostack
git-subtree-split: 4a19dc4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@jeromecoutant @LMESTM @PrzemekWirkus @0xc0170 @mbed-bot @bridadan @devanlai