Skip to content

Conversation

@SeppoTakalo
Copy link
Contributor

@SeppoTakalo SeppoTakalo commented Jul 13, 2016

Add documentation about the .mbedignore file.

Please wait for someone to check the language before merging.

@SeppoTakalo
Copy link
Contributor Author

@bogdanm @screamerbg or @sg- Please review.

@screamerbg
Copy link
Contributor

👍 LGTM

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skip the first sentence. Instead start: The .mbedignore file allows you to ignore...

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 14, 2016

shall the doc name be mbed_ignore_file or might be better to have : build_system (ignore file would be part of the bigger document about our build system, to describe how we build our sources and how we can ignore, etc) rather than Ignoring_files_from_build (I would not capital I in the name, the other docs do not use it neither).

@SeppoTakalo
Copy link
Contributor Author

Edited. Pekka's suggestions taken into use.

@0xc0170 I agree that this should be part of the build system documentation. However, the BUILDING.md documentation currently talks about testing. So the basic build system documentation is still missing. Or maybe that needs to be split into two parts, building and testing. Therefore I suggest that this goes in as a separate file, and we will integrate these later when forming the explanation of build system.

This is ready to be merged.

@0xc0170 0xc0170 merged commit 8d1d836 into ARMmbed:master Jul 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants