Skip to content

Remove floating point formatting in newlib nano #2168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 26, 2016

Conversation

c1728p9
Copy link
Contributor

@c1728p9 c1728p9 commented Jul 13, 2016

Remove special case targets which have floating point enabled in
Newlib Nano from gcc.py. To enable floating point printf/scanf
for a target configure it to use the 'standard' default build in
targets.json rather than 'small'.

Remove special case targets which have floating point enabled in
Newlib Nano from gcc.py.  To enable floating point printf/scanf
for a target configure it to use the 'standard' default build in
targets.json rather than 'small'.
@c1728p9
Copy link
Contributor Author

c1728p9 commented Jul 13, 2016

@mbed-bot: TEST

HOST_OSES=ALL
BUILD_TOOLCHAINS=ALL
TARGETS=ALL

@mbed-bot
Copy link

[Build 623]
FAILURE: Something went wrong when building and testing.

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 14, 2016

Test results: OK

A question : this would be non breaking if all targets in the list there are built with newlib (not small nano). Are they? Looking at them, NUCLEO_F410RB is with small. We know that there are some issues with nucleo targets for uARM (there's one PR open that can help us with this, it needs review). I'll have a look and get back to this. Or another option, as this is for gcc -> it's used offline only, we could display a logging warning that this has changed, and floating stdout/in is not enabled now (if target is in the list + standard lib == small -> display warning).

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 14, 2016

Depends on https://github.com/mbedmicro/mbed/pull/2098/files. That one fixes all targets we care in this list removal, I checked, all of them would be then standard lib -> non-breaking change

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 22, 2016

2098 was merged, this should be good to go

@screamerbg please review

@screamerbg
Copy link
Contributor

LGTM. Mind if I ask Renesas team to confirm? They had some concerns

@bridadan
Copy link
Contributor

/morph test

@mbed-bot
Copy link

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 508

Test failed!

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 25, 2016

@TomoYamanaka Are you happy with this change?

@TomoYamanaka
Copy link
Contributor

Thank you for your information.
Renesas team is now reviewing about this changing.

@TomoYamanaka
Copy link
Contributor

In this floating point formatting problems,
if the main cause is that using the "newlib-nano", there is no problem with this change.

@sg- sg- merged commit 381b352 into ARMmbed:master Jul 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants