-
Notifications
You must be signed in to change notification settings - Fork 3k
Remove floating point formatting in newlib nano #2168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Remove special case targets which have floating point enabled in Newlib Nano from gcc.py. To enable floating point printf/scanf for a target configure it to use the 'standard' default build in targets.json rather than 'small'.
@mbed-bot: TEST HOST_OSES=ALL |
[Build 623] |
Test results: OK A question : this would be non breaking if all targets in the list there are built with newlib (not small nano). Are they? Looking at them, |
Depends on https://github.com/mbedmicro/mbed/pull/2098/files. That one fixes all targets we care in this list removal, I checked, all of them would be then standard lib -> non-breaking change |
2098 was merged, this should be good to go @screamerbg please review |
LGTM. Mind if I ask Renesas team to confirm? They had some concerns |
/morph test |
Result: FAILUREYour command has finished executing! Here's what you wrote!
Outputmbed Build Number: 508 Test failed! |
@TomoYamanaka Are you happy with this change? |
Thank you for your information. |
In this floating point formatting problems, |
Remove special case targets which have floating point enabled in
Newlib Nano from gcc.py. To enable floating point printf/scanf
for a target configure it to use the 'standard' default build in
targets.json rather than 'small'.