Remove LF clock initialization from os_init_clock. #2213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The LF clock initialization is already handled by the SystemInit function. This code was causing troubles when run on targets with an alternate LF clock.
|
@mbed-bot: TEST HOST_OSES=windows |
|
[Build 665] |
|
I think this one can land first, it is not a breaking change for other targets but it really needed for RTOS support, even in single thread! |
|
LGTM 👍 @c1728p9 |
|
Looks good to me as well. I can confirm that this fixes the microbit problem I was seeing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The LF clock initialization is already handled by the SystemInit function.
This code was causing troubles when run on targets with an alternate LF
clock.
This fix #2132 and allows RTOS to run on targets like the NRF51_MICROBIT.