-
Notifications
You must be signed in to change notification settings - Fork 3k
Improvements to k64 internal-flash storage driver #2219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements to k64 internal-flash storage driver #2219
Conversation
…o RWW The RWW fix is controversial because it requires holding off interrupts for periods of around 5ms at a time. But there were still some minor improvements around that change which could be retained. This commit contains these changes.
This should help avoid conflicts with configs for other Storage devices in the future.
With this change, we check for all-1s before executing erase. This means that the cost of erasing a range is now proportional to the amount of sectors which have been programmed. This should result in latency improvements in our use of containers based on flash storage.
@mbed-bot: TEST HOST_OSES=windows,linux |
[Build 668] |
LGTM |
[Build 670] |
@rgrover Sorry about that, this was caused by an erroneous issue with mbed-ls. I've updated the version used on the server so this should be fixed. |
@mbed-bot: TEST HOST_OSES=windows |
/morph test |
Result: FAILUREYour command has finished executing! Here's what you wrote!
Outputmbed Build Number: 480 A build failure occurred! |
[Build 680] |
@mbed-bot: TEST HOST_OSES=windows |
[Build 682] |
/morph test |
Result: FAILUREYour command has finished executing! Here's what you wrote!
Outputmbed Build Number: 503 Test failed! |
/morph test |
Result: FAILUREYour command has finished executing! Here's what you wrote!
Outputmbed Build Number: 505 Test failed! |
/morph test |
1 similar comment
/morph test |
Result: FAILUREYour command has finished executing! Here's what you wrote!
Outputmbed Build Number: 535 Test failed! |
@mbed-bot: TEST HOST_OSES=windows |
[Build 720] |
Note: This change-set doesn't have the following (as requested by @mjs-arm):
We still need to resolve if ASYNC operation is to be forced since there are some internal use cases which rely upon synchronous operation.
review: @0xc0170 @sg-
notify: @mjs-arm @marcuschangarm @simonqhughes @meriac