Skip to content

Improvements to k64 internal-flash storage driver #2219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jul 27, 2016
Merged

Improvements to k64 internal-flash storage driver #2219

merged 8 commits into from
Jul 27, 2016

Conversation

rgrover
Copy link
Contributor

@rgrover rgrover commented Jul 22, 2016

Note: This change-set doesn't have the following (as requested by @mjs-arm):

  • MUST - Hardwire the K64F storage driver to ASYNC only operation (not user >configurable).

We still need to resolve if ASYNC operation is to be forced since there are some internal use cases which rely upon synchronous operation.

review: @0xc0170 @sg-
notify: @mjs-arm @marcuschangarm @simonqhughes @meriac

Rohit Grover added 8 commits July 22, 2016 09:14
…o RWW

The RWW fix is controversial because it requires holding off interrupts for
periods of around 5ms at a time. But there were still some minor improvements
around that change which could be retained. This commit contains these
changes.
This should help avoid conflicts with configs for other Storage devices in the
future.
With this change, we check for all-1s before executing erase. This means that
the cost of erasing a range is now proportional to the amount of sectors which
have been programmed. This should result in latency improvements in our use of
containers based on flash storage.
@rgrover
Copy link
Contributor Author

rgrover commented Jul 22, 2016

@mbed-bot: TEST

HOST_OSES=windows,linux
BUILD_TOOLCHAINS=GCC_ARM,ARM,IAR
TARGETS=K64F

@mbed-bot
Copy link

[Build 668]
FAILURE: Something went wrong when building and testing.

@rgrover
Copy link
Contributor Author

rgrover commented Jul 22, 2016

I don't understand why this previous build was marked as a failure. It did pass according to TestResultViewer. @bridadan

@mbed-bot: TEST

HOST_OSES=windows,linux
BUILD_TOOLCHAINS=GCC_ARM,ARM,IAR
TARGETS=K64F

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 22, 2016

LGTM

@mbed-bot
Copy link

[Build 670]
FAILURE: Something went wrong when building and testing.

@rgrover
Copy link
Contributor Author

rgrover commented Jul 22, 2016

@bridadan @sg- I don't see why automated testing failed here.

@bridadan
Copy link
Contributor

@rgrover Sorry about that, this was caused by an erroneous issue with mbed-ls. I've updated the version used on the server so this should be fixed.

@sg-
Copy link
Contributor

sg- commented Jul 22, 2016

@mbed-bot: TEST

HOST_OSES=windows
BUILD_TOOLCHAINS=GCC_ARM,ARM,IAR
TARGETS=K64F,NRF51_DK,NUCLEO_F411RE

@sg-
Copy link
Contributor

sg- commented Jul 22, 2016

/morph test

@mbed-bot
Copy link

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 480

A build failure occurred!

@mbed-bot
Copy link

[Build 680]
FAILURE: Something went wrong when building and testing.

@sg-
Copy link
Contributor

sg- commented Jul 22, 2016

@mbed-bot: TEST

HOST_OSES=windows
BUILD_TOOLCHAINS=GCC_ARM,ARM,IAR
TARGETS=K64F,NRF51_DK,NUCLEO_F411RE

@mbed-bot
Copy link

[Build 682]
SUCCESS: Building succeeded and tests were run! Be sure to check the test results

@sg-
Copy link
Contributor

sg- commented Jul 24, 2016

/morph test

@mbed-bot
Copy link

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 503

Test failed!

@bridadan
Copy link
Contributor

/morph test

@mbed-bot
Copy link

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 505

Test failed!

@sg-
Copy link
Contributor

sg- commented Jul 26, 2016

/morph test

1 similar comment
@sg-
Copy link
Contributor

sg- commented Jul 26, 2016

/morph test

@mbed-bot
Copy link

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 535

Test failed!

@sg-
Copy link
Contributor

sg- commented Jul 27, 2016

@mbed-bot: TEST

HOST_OSES=windows
BUILD_TOOLCHAINS=GCC_ARM,ARM,IAR
TARGETS=K64F,NUCLEO_F411RE

@mbed-bot
Copy link

[Build 720]
SUCCESS: Building succeeded and tests were run! Be sure to check the test results

@sg- sg- merged commit 09f9c0e into ARMmbed:master Jul 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants