Skip to content

Define stack size of the threads spawned by RTOS threads test. #2248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 27, 2016

Conversation

pan-
Copy link
Member

@pan- pan- commented Jul 25, 2016

This stack size is adjusted for NRF51 and NRF52 based targets.
This should help: #2211

This stack size is adjusted for NRF51 and NRF52 based targets.
@pan-
Copy link
Member Author

pan- commented Jul 25, 2016

@sg- @geky Could you review this ?

@geky
Copy link
Contributor

geky commented Jul 25, 2016

That looks good to me, although is there any reason to not use the explicit stack-size for every platform?

@pan-
Copy link
Member Author

pan- commented Jul 25, 2016

Yes, this test cause issues with IAR on NRF51 and NRF52.
With IAR the heap is fixed in the linker script (it can't be (AFAIK) RAM - other_sections_in_RAM).
In my case, the heap is fixed to a size comfortable size of 0x1800.
The default thread stack is set to 2048 bytes.

Just spawn 3 threads with a default stack size to blow up the system.

@geky
Copy link
Contributor

geky commented Jul 25, 2016

Why not 512 for all platforms? Is there a reason to use DEFAULT_STACK_SIZE on other platforms?

@sg-
Copy link
Contributor

sg- commented Jul 26, 2016

@mbed-bot: TEST

HOST_OSES=windows
BUILD_TOOLCHAINS=GCC_ARM,ARM,IAR
TARGETS=K64F,NRF51_DK,NRF51_MICROBIT,NUCLEO_F411RE

@sg-
Copy link
Contributor

sg- commented Jul 26, 2016

/morph test

@mbed-bot
Copy link

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 519

Test failed!

@mbed-bot
Copy link

[Build ${MBED_BUILD_ID}]
FAILURE: Something went wrong when building and testing.

@sg-
Copy link
Contributor

sg- commented Jul 26, 2016

@mbed-bot: TEST

HOST_OSES=windows
BUILD_TOOLCHAINS=GCC_ARM
TARGETS=K64F,NRF51_DK,NRF51_MICROBIT,NUCLEO_F411RE

@mbed-bot
Copy link

[Build 702]
FAILURE: Something went wrong when building and testing.

@pan- pan- changed the title Define stack size of the threads spawned by this test. Define stack size of the threads spawned by RTOS threads test. Jul 26, 2016
@pan-
Copy link
Member Author

pan- commented Jul 26, 2016

@sg same as in #2247 the output is passing.
What is wrong with the build bot ?

@sg-
Copy link
Contributor

sg- commented Jul 26, 2016

What is wrong with the build bot ?

It was tired and needed a rest :)

@sg-
Copy link
Contributor

sg- commented Jul 26, 2016

/morph test

@sg-
Copy link
Contributor

sg- commented Jul 26, 2016

@mbed-bot: TEST

HOST_OSES=windows
BUILD_TOOLCHAINS=GCC_ARM,ARM,IAR
TARGETS=K64F,NRF51_DK,NRF51_MICROBIT,NUCLEO_F411RE

@mbed-bot
Copy link

[Build 716]
SUCCESS: Building succeeded and tests were run! Be sure to check the test results

@mbed-bot
Copy link

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 532

Test failed!

@sg- sg- merged commit c24e461 into ARMmbed:master Jul 27, 2016
@pan- pan- deleted the define_stack_stize_for_RTOS_threads_test branch September 27, 2016 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants