Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NRF52_DK target publication #2314

Closed
wants to merge 2 commits into from
Closed

NRF52_DK target publication #2314

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e7d08bd
Set the public flag for the NRF52_DK target.
nvlsianpu Jul 29, 2016
af257bc
a coma--
nvlsianpu Jul 29, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion hal/targets.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1939,7 +1939,8 @@
"NRF52_PAN_63"
],
"device_has": ["ANALOGIN", "ERROR_PATTERN", "I2C", "I2C_ASYNCH", "INTERRUPTIN", "LOWPOWERTIMER", "PORTIN", "PORTINOUT", "PORTOUT", "PWMOUT", "RTC", "SERIAL", "SERIAL_ASYNCH", "SLEEP", "SPI", "SPI_ASYNCH", "SPISLAVE"],
"release_versions": ["2", "5"]
"release_versions": ["2", "5"],
"public": true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As explained here, the public attribute defaults to true if not specified. Are you unable to use this target without setting public to true?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was asked by @screamerbg to do so:

The steps to follow by the end of this week:
• Pull request with “public” flag set for the NRF52_DK target in targets.json (https://github.com/mbedmicro/mbed repository)
Could you took to him in this topic?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Obviously this definition is not necessary for the release of NRF52_DK target.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"public" is a bit misleading here. Seems it should be something like "inheritable", "protected", etc.. I'm sure there are OO descriptions that better describe what and how its used.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, it is a bit misleading. How about we rename it to internal and add it only to internal targets? Or maybe private?

},
"BLUEPILL_F103C8": {
"core": "Cortex-M3",
Expand Down