KL27Z: Fix duplicate define error #2400
Conversation
Signed-off-by: Mahadevan Mahesh <Mahesh.Mahadevan@nxp.com>
| #endif /* FSL_FEATURE_SPI_16BIT_TRANSFERS */ | ||
|
|
||
| #if defined(FSL_FEATURE_SPI_FIFO_SIZE) && (FSL_FEATURE_SPI_FIFO_SIZE > 1) | ||
| #if defined(FSL_FEATURE_SPI_HAS_FIFO) && (FSL_FEATURE_SPI_HAS_FIFO) |
There was a problem hiding this comment.
The old code was using a macro that is not available.
There was a problem hiding this comment.
Ah I missed first check is defined, the second is checking if it's set to non zero value. ;) All good
There was a problem hiding this comment.
The first check is not needed http://stackoverflow.com/questions/5085392/what-is-the-value-of-an-undefined-constant-used-in-if
There was a problem hiding this comment.
We had discussed about this, however there were some use-cases which required this.
I do not want to make changes that deviates from the SDK code base.
There was a problem hiding this comment.
@theotherjimmy It's correct but some compilers create a warning, that a macro is not defined (we had this problem with some cortex cmsis defines).
|
Any update? |
3 participants
Signed-off-by: Mahadevan Mahesh Mahesh.Mahadevan@nxp.com