Utest: default copy constructor for failure_t doesn't behave as expected

[adbridge]

Description

Fixes issue #2508.

The default compiler(ARMCC) copy constructor for failure_t doesn't behave as
expected and has unexpected side effects. This fix adds a custom copy constructor
to fix this.

[adbridge]

@0xc0170 This is the reproduction of the fix that was previously reviewed/merged/tested on the pre-5.1 mbed-os. Please give it a quick once over review and merge .

[0xc0170]

/morph test

[mbed-bot]

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 681

Test failed!

[sg-]

@bridadan

[bridadan]

/morph echo

[mbed-bot]

I recieved your comment! Here's what you wrote!

/morph echo

[bridadan]

/morph test

[mbed-bot]

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 683

Test failed!

[adbridge]

So we have:
K64F-IAR | K64F | tests-mbedmicro-rtos-mbed-basic | TIMEOUT | 46.68 |
KL46Z-IAR | KL46Z | features-frameworks-utest-tests-unit_tests-test_setup_failure | TIMEOUT | 57.42 |
NRF51_DK-ARM | NRF51_DK | features-frameworks-utest-tests-unit_tests-test_assertion_failure_test_setup | TIMEOUT | 76.42 | shell |

Timeouts usually mean the devices didn't reset and get flashed correctly. Looking more closely at the failures, looks like the device has either crashed or not been flashed correctly. This is a test system issue, thus I'm happy this fix can be merged!

[0xc0170]

/morph test

[mbed-bot]

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 720

All builds and test passed!