Removed custom targets from config system #2691
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Custom targets were the origin of a number of issues with the mbed tools, so it was decided that they need to be removed. This PR does just that (and moves the "custom_targets" part of the config system tests into a separate, per-test "targets.json" file to preserve the test functionality).
| if os.path.isfile(os.path.join(full_name, "targets.json")): | ||
| set_targets_json_location(os.path.join(full_name, "targets.json")) | ||
| else: # uset the regular set of targets | ||
| set_targets_json_location(Target._Target__targets_json_location_default) |
There was a problem hiding this comment.
I'm pretty sure you can leave off the argument to set_targets_json_location and have the same behavior. This would prevent you from relying on a 'hiden' class variable.
|
LGTM. 👍 |
The previous code used a variable that was internal to the Target class. This commit removes the argument to `set_targets_json_location` completely, which forces Target to use the default locatio internally.
|
Good point @theotherjimmy, thanks! Fixed. |
|
@bogdanm That was fast! It all looks good to me. |
|
@bogdanm Where is the documentation for the |
|
@pan-: that was a function added to support the online build system, and now found another use in the tests for the configuration system. It's not really for internal use only, but I don't think we really want to encourage people to use it. I might be wrong though. |
|
LGTM. This will also reduce complexity! |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Custom targets were the origin of a number of issues with the mbed
tools, so it was decided that they need to be removed. This PR does just
that (and moves the "custom_targets" part of the config system tests
into a separate, per-test "targets.json" file to preserve the test
functionality).