Skip to content

[LPC1347] Fix PwmOut prescaler for 16-bit timer #2810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 28, 2016
Merged

Conversation

toyowata
Copy link
Contributor

Description

Fix PwmOut prescaler for 16-bit timer on the LPC1347 platform.
See #2660 more detail.

Status

READY

Steps to test or reproduce

#2660 (comment)

Test result

Automated test result

Test summary:
+---------------+---------+-----------+-------------+---------------------------------------+--------------------+---------------+-------+
| Result        | Target  | Toolchain | Test ID     | Test Description                      | Elapsed Time (sec) | Timeout (sec) | Loops |
+---------------+---------+-----------+-------------+---------------------------------------+--------------------+---------------+-------+
| OK            | LPC1347 | ARM       | DTCT_1      | Simple detect test                    |        0.51        |       10      |  1/1  |
| OK            | LPC1347 | ARM       | EXAMPLE_1   | /dev/null                             |        3.5         |       20      |  1/1  |
| OK            | LPC1347 | ARM       | MBED_10     | Hello World                           |        0.39        |       5       |  1/1  |
| OK            | LPC1347 | ARM       | MBED_11     | Ticker Int                            |       11.38        |       15      |  1/1  |
| OK            | LPC1347 | ARM       | MBED_12     | C++                                   |        1.4         |       10      |  1/1  |
| NOT_SUPPORTED | LPC1347 | ARM       | MBED_16     | RTC                                   |         0          |       0       |   -   |
| OK            | LPC1347 | ARM       | MBED_2      | stdio                                 |        0.74        |       20      |  1/1  |
| OK            | LPC1347 | ARM       | MBED_23     | Ticker Int us                         |       11.36        |       15      |  1/1  |
| OK            | LPC1347 | ARM       | MBED_24     | Timeout Int us                        |       11.54        |       15      |  1/1  |
| OK            | LPC1347 | ARM       | MBED_25     | Time us                               |       11.39        |       15      |  1/1  |
| OK            | LPC1347 | ARM       | MBED_26     | Integer constant division             |        1.4         |       20      |  1/1  |
| OK            | LPC1347 | ARM       | MBED_34     | Ticker Two callbacks                  |       11.38        |       15      |  1/1  |
| FAIL          | LPC1347 | ARM       | MBED_37     | Serial NC RX                          |        1.95        |       20      |  0/1  |
| FAIL          | LPC1347 | ARM       | MBED_38     | Serial NC TX                          |        0.93        |       20      |  0/1  |
| OK            | LPC1347 | ARM       | MBED_A1     | Basic                                 |        1.38        |       20      |  1/1  |
| OK            | LPC1347 | ARM       | MBED_A21    | Call function before main (mbed_main) |        1.46        |       20      |  1/1  |
| OK            | LPC1347 | ARM       | MBED_A9     | Serial Echo at 115200                 |        6.36        |       20      |  1/1  |
| OK            | LPC1347 | ARM       | MBED_BUSOUT | BusOut                                |        2.32        |       15      |  1/1  |
+---------------+---------+-----------+-------------+---------------------------------------+--------------------+---------------+-------+
Result: 2 FAIL / 15 OK / 1 NOT_SUPPORTED

Completed in 150.98 sec

Manual test MBED_5 result

Initialize PWM on P0_18 with duty cycle: 0.75
Initialize PWM on P0_9 with duty cycle: 0.50
{{success}}
{{end}}

* Fix PwmOut prescaler for 16-bit timer
* Remove static variable pwm_clock_mhz
* Fix spike pulse issue when 0% duty
@sg-
Copy link
Contributor

sg- commented Sep 28, 2016

@mbed-bot: TEST

HOST_OSES=ALL
BUILD_TOOLCHAINS=ALL
TARGETS=ALL

@mbed-bot
Copy link

[Build 992]
SUCCESS: Building succeeded and tests were run! Be sure to check the test results

@sg- sg- merged commit 7608401 into ARMmbed:master Sep 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants