[STM32 NUCLEO] Init MAC address #2812
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sg-
suggested changes
Sep 28, 2016
|
|
||
| void mbed_mac_address(char *mac) { | ||
| if (mbed_otp_mac_address(mac)) { | ||
| return; |
There was a problem hiding this comment.
looks like too many spaces here
| if (mbed_otp_mac_address(mac)) { | ||
| return; | ||
| } else { | ||
| mbed_default_mac_address(mac); |
|
@andreaslarssonublox does this work for you? |
|
I think it looks ok. |
|
/morph test |
Result: FAILUREYour command has finished executing! Here's what you wrote!
Outputmbed Build Number: null Examples Build failed! |
|
Oops this was my fault! Messing with CI again, retriggering now. /morph test |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
Outputmbed Build Number: 992 All builds and test passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
New Pull Request after #2808 and #2743
@andreaslarssonublox
Status
READY