STM32 - Rename RTC_LSI #2816
Merged
STM32 - Rename RTC_LSI #2816
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@svastm Good idea. 1 question though : have you seen any side effects of this macro, or is it purely a cosmetic change ? |
|
I did not seen any change. It's just because RTC_LSI is a macro only used by ST and should not be prefixed by |
svastm
force-pushed
the
rename_rtc_lsi
branch
from
6bd0f51 to
c69f7e0
Compare
|
Ok clear- definitely a good idea for me +1 |
|
retest uvisor |
4 similar comments
|
retest uvisor |
|
retest uvisor |
|
retest uvisor |
|
retest uvisor |
|
/morph test |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
Outputmbed Build Number: 991 All builds and test passed! |
svastm
force-pushed
the
rename_rtc_lsi
branch
from
c69f7e0 to
d37e4d8
Compare
|
Rebased, every macro should be renamed now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The macro was wrongly named
DEVICE_RTC_LSIwhile it is not a part ofDEVICE_api. This PR rename it toRTC_LSIStatus
IN DEVELOPMENT
Migrations
NO
Todos