-
Notifications
You must be signed in to change notification settings - Fork 3k
Change K64F D8 pin from PTA0->PTC12 #2934
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Modifying D8 to reflect latest hardare changes in RevD hardware #2933
Another win for the CI Test Shield |
What people do with older revisions? This can be considered a breaking change? however PTA0 is not jtag pin? :-)) |
@BlackstoneEngineering like @0xc0170 said will this affect older revisions? Have you tested older revisions? |
I have not tested on older versions. If we are not going to change this then we need to mark that pin as unusable. As it stands anyone who buys a board gets screwed, and will continue to going forward. |
I think a warning on the platform page about the inconsistency would be the best bet for now, like you said |
Dude, its been a couple years now, we should just assume the majority of boards are RevD, all we're doing now is cripling the existing line and the majority of boards for backwards compatibility. I think the note on the platforms page should address the different hardware revisions and instruct users to use the microcontroller pin names for older platforms, thus keeping the Arduino pin names updates to the latest hardware revision. |
I agree with @BlackstoneEngineering. The RevD platform is stable and is the majority platform in use today. Older rev users can drop down to the MCU pin names instead of the header pin names. (FYI @mmahadevan108) |
The commit message should be corrected to PTA0->PTC12. @mnorman4 The below link says rev E3 in the picture showing Arduino headers, this should be changed to rev E4. Thanks. |
done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @mnorman4 !
@mnorman4 Do you think it would be appropriate to add a |
@BlackstoneEngineering +1 for adding the |
Description
Modifying D8 to reflect latest hardare changes in RevD hardware
#2933