Skip to content

Change K64F D8 pin from PTA0->PTC12 #2934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 7, 2016
Merged

Change K64F D8 pin from PTA0->PTC12 #2934

merged 1 commit into from
Oct 7, 2016

Conversation

BlackstoneEngineering
Copy link
Contributor

Description

Modifying D8 to reflect latest hardare changes in RevD hardware
#2933

Modifying D8 to reflect latest hardare changes in RevD hardware
#2933
@BlackstoneEngineering
Copy link
Contributor Author

Another win for the CI Test Shield

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 6, 2016

What people do with older revisions? This can be considered a breaking change? however PTA0 is not jtag pin? :-))

@bridadan
Copy link
Contributor

bridadan commented Oct 6, 2016

@BlackstoneEngineering like @0xc0170 said will this affect older revisions? Have you tested older revisions?

@BlackstoneEngineering
Copy link
Contributor Author

I have not tested on older versions. If we are not going to change this then we need to mark that pin as unusable. As it stands anyone who buys a board gets screwed, and will continue to going forward.

@bridadan
Copy link
Contributor

bridadan commented Oct 6, 2016

I think a warning on the platform page about the inconsistency would be the best bet for now, like you said

@BlackstoneEngineering
Copy link
Contributor Author

Dude, its been a couple years now, we should just assume the majority of boards are RevD, all we're doing now is cripling the existing line and the majority of boards for backwards compatibility. I think the note on the platforms page should address the different hardware revisions and instruct users to use the microcontroller pin names for older platforms, thus keeping the Arduino pin names updates to the latest hardware revision.

@mnorman4
Copy link

mnorman4 commented Oct 6, 2016

I agree with @BlackstoneEngineering. The RevD platform is stable and is the majority platform in use today. Older rev users can drop down to the MCU pin names instead of the header pin names. (FYI @mmahadevan108)

@mmahadevan108
Copy link
Contributor

The commit message should be corrected to PTA0->PTC12.

@mnorman4 The below link says rev E3 in the picture showing Arduino headers, this should be changed to rev E4.
https://developer.mbed.org/platforms/FRDM-K64F/

Thanks.

@BlackstoneEngineering BlackstoneEngineering changed the title Change K64F D8 pin from PTA0->PTC4 Change K64F D8 pin from PTA0->PTC12 Oct 6, 2016
@BlackstoneEngineering
Copy link
Contributor Author

done

Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @mnorman4 !

@sg- sg- merged commit f59b5f8 into ARMmbed:master Oct 7, 2016
@BlackstoneEngineering
Copy link
Contributor Author

@mnorman4 Do you think it would be appropriate to add a <note> </note> just under the K64F pinout on the platform page warning about different pins for different revisions? Otherwise it is entirely possible for an end user to run into this issue and not be able to figure it out.

@bridadan
Copy link
Contributor

@BlackstoneEngineering +1 for adding the <note> </note> on the platform page!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants