DNS: Fix return value for successful name resolutions #2963
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There was an unrelated change to this function that slightly changed the logic. Are you sure the |
|
Yeah you're probably right, we should still return error when the count is 0. |
|
/morph test |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
Outputmbed Build Number: 1078 All builds and test passed! |
kjbracey
reviewed
Oct 10, 2016
| @@ -243,8 +243,11 @@ static int nsapi_dns_query_multiple(NetworkStack *stack, const char *host, | |||
| } | |||
|
|
|||
| const uint8_t *response = packet; | |||
| dns_scan_response(&response, addr, addr_count); | |||
| break; | |||
| if (!dns_scan_response(&response, addr, addr_count)) { | |||
There was a problem hiding this comment.
Don't like using "!" for non-boolean values. "== 0" would have been clearer.
Also, you end up querying every DNS server when the destination doesn't exist (like 5.1 did). The point of extra DNS servers is to provide a backup if one goes down, not to get second opinions.
And you return "OK" if no servers respond.
Better fix is:
if (dns_scan_response(&response, addr, addr_count) > 0) {
result = NSAPI_ERROR_OK;
}
break;
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
DNS name resolution was returning error even for successful cases
Status
READY
CC: @geky @0xc0170