-
Notifications
You must be signed in to change notification settings - Fork 3k
Fix file path quoting while constructing CSV file in memmap.py #2964
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Comma is a valid char in file paths for Posix systems.
@bulislaw Interesting bug! Could you please post the full path that's causing the issue you're seeing on your machine? It'll be easier to reproduce this. |
I think it's that's the full listing:
|
/morph test |
Thanks for the info, I see the problem now. It requires replacing ',' chars by something else. |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
Outputmbed Build Number: 1089 All builds and test passed! |
Description
I'm getting:
I've tracked it down to using unquoted ',' to build CSV file. The default behavior is to rise error when the parser hits delimiter char. Comma is an legal character in file path in POSIX systems (including default Linaro ARM GCC package).
It stopped working for me today.
I'm actually not sure whether that's the right solution. @theotherjimmy can you have a look please?
Steps to test or reproduce
Try
mbed compile
on POSIX system when one of the used files (eg compiler) has,
in filepath.