Ublox drivers #2977

andreaslarssonublox · 2016-10-11T01:39:52Z

Description

This is the first binary for the u-blox ODIN-W2 wireless drivers.
Don't know whether this should go into a branch or master.

Limitations

WEP is not implemented yet.
The OdinWiFiInterface class can only be instantiated once.

Status

IN DEVELOPMENT

Migrations

NO

Related PRs

#2874

Todos

Tests
Documentation

A couple of Wi-Fi test cases should be written but this is outside of this PR.
The existing lwip tests fail now so they shall be adapted or excluded.

For u-blox mbed 3 ODIN-W2 driver C API there is some documentation here:
https://github.com/u-blox/ublox-odin-w2-drivers-binary

@screamerbg
Should some similar documentation for mbed 5 go into the sdk-folder or is it better suited on u-blox homepage or the board page hosted by ARM?

Deploy notes

Steps to test or reproduce

The binary was built based on the following in mbed-os:
SHA-1: 62bc686

The binary was built based on the following u-blox ODIN-W2 drivers:
SHA-1: 251f79b706178e97eb1445dba2e17304ec782a14

Some basic tests have been manually done:
connect open, connect WPA2, scan, get RSSI, disconnect.

andreaslarssonublox · 2016-10-11T01:40:25Z

@0xc0170

0xc0170 · 2016-10-11T13:29:13Z

Master shall be fine but not certain if release version for 5 is valid in this case (the requirement gcc + iar + armcc support).

Notes:

the odin interface implementation is part of the archive at the moment, will be open later.
ARMCC and IAR compatible driver archives are in progress

cc @bulislaw @geky @sg- Please review

bulislaw

All your headers have license that we can't really accept, could you update it to PBL please.
Also you're using global state, which for now is fine, but when we change the implementation to support multiple stacks could possibly be an issue.

bulislaw · 2016-10-11T15:25:23Z

...ET_STM/TARGET_STM32F4/TARGET_UBLOX_EVK_ODIN_W2/sdk/ublox-odin-w2-drivers/OdinWiFiInterface.h

+public:
+    /** OdinWiFiInterface lifetime
+     */
+	OdinWiFiInterface();


The indentation is all over the place in this file.

Thanks will fix!

bulislaw · 2016-10-11T15:38:04Z

targets/TARGET_STM/TARGET_STM32F4/TARGET_UBLOX_EVK_ODIN_W2/sdk/ublox-odin-w2-drivers/bt_types.h

@@ -0,0 +1,193 @@
+/*---------------------------------------------------------------------------


I don't think we can get that 'license' in. You should license your headers the same way you license your binary that is PBL.

Ok, we will look into if it's possible to use this one instead:
https://www.mbed.com/en/licenses/permissive-binary-license/

sg- · 2016-10-11T18:49:38Z

targets/targets.json

@@ -1186,7 +1186,7 @@
        "extra_labels": ["STM", "STM32F4", "STM32F439", "STM32F439ZI"],
        "macros": ["HSE_VALUE=24000000", "HSE_STARTUP_TIMEOUT=5000", "CB_INTERFACE_SDIO","CB_CHIP_WL18XX","SUPPORT_80211D_ALWAYS","WLAN_ENABLED"],
        "inherits": ["Target"],
-        "device_has": ["ANALOGIN", "CAN", "I2C", "I2CSLAVE", "INTERRUPTIN", "PORTIN", "PORTINOUT", "PORTOUT", "PWMOUT", "SERIAL", "SLEEP", "SPI", "SPISLAVE", "STDIO_MESSAGES"],
+        "device_has": ["ANALOGIN", "EMAC", "CAN", "I2C", "I2CSLAVE", "INTERRUPTIN", "PORTIN", "PORTINOUT", "PORTOUT", "PWMOUT", "SERIAL", "SLEEP", "SPI", "SPISLAVE", "STDIO_MESSAGES"],
        "features": ["LWIP"],
        "release_versions": ["5"],


lets remove the release version until we get this cleaned up, formatting and three compilers

Sam do you think it's allright to keep the release version as we cleaned stuff up and got all 3 compilers in place?

If there isnt support for the 3 compilers this will fail CI and should not be turned on until it passes all CI

there is support for all 3 compilers now.

If it passes CI, then we're good!

Let's see - I'll start the tests.

sg- · 2016-10-11T18:49:50Z

targets/targets.json

@@ -1186,7 +1186,7 @@
        "extra_labels": ["STM", "STM32F4", "STM32F439", "STM32F439ZI"],
        "macros": ["HSE_VALUE=24000000", "HSE_STARTUP_TIMEOUT=5000", "CB_INTERFACE_SDIO","CB_CHIP_WL18XX","SUPPORT_80211D_ALWAYS","WLAN_ENABLED"],
        "inherits": ["Target"],
-        "device_has": ["ANALOGIN", "CAN", "I2C", "I2CSLAVE", "INTERRUPTIN", "PORTIN", "PORTINOUT", "PORTOUT", "PWMOUT", "SERIAL", "SLEEP", "SPI", "SPISLAVE", "STDIO_MESSAGES"],
+        "device_has": ["ANALOGIN", "EMAC", "CAN", "I2C", "I2CSLAVE", "INTERRUPTIN", "PORTIN", "PORTINOUT", "PORTOUT", "PWMOUT", "SERIAL", "SLEEP", "SPI", "SPISLAVE", "STDIO_MESSAGES"],


I don't see where EMAC is used in this patch

Macro is used on the mbed-os side, to pull in right bits for the EMAC API.

bulislaw · 2016-10-13T22:13:09Z

/morph test

bulislaw · 2016-10-13T22:17:47Z

Ah actually that was pointless as there is no Odin boards in the farm... @andreaslarssonublox can you run the test locally and paste the results here please.

bulislaw · 2016-10-13T23:24:07Z

@sg- we seem to have Ethernet tests failing, that's expected as we can't have both Ethernet and WiFi working at the same time. So we can either by default disable WiFi (EMAC flag) or change tests not to run in case of EMAC. We should be able to fix it properly when we get the network unification done.

andreaslarssonublox · 2016-10-13T23:48:45Z

All tests passed for the UBLOX_EVK_ODIN_W2 target except lwip/ethernet.

arm.txt
gcc.txt
iar.txt

Going to remove EMAC from target.json as well to see that nothing is broken and ethernet works.

andreaslarssonublox · 2016-10-14T00:40:35Z

There were problems in the wifi_emac_api.cpp that have been fixed now when removing EMAC in target.json. I will push the file once I got some test results.

andreaslarssonublox · 2016-10-14T00:52:33Z

I ran one test case for eth/lwip without EMAC in target.json to verify that it works:
results_iar_gcc_arm_lwip_eth_one_test_case.txt

Will rerun the test cases for the standard configuration(with EMAC) for the new commit for all compilers. Would that be enough?

@sg- @bulislaw Anything decided yet on failing eth tests?

andreaslarssonublox · 2016-10-14T01:16:27Z

All OK except lwip/eth as expected for GCC/ARM/IAR toolchain:

results_gcc.txt
results_arm.txt
results_iar.txt

mbed-bot · 2016-10-14T04:56:09Z

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 0

All builds and test passed!

Currently only one network interface can be compiled in at a given time, to avoid failing automated test on this target WiFi will be disabled by default.

bulislaw · 2016-10-14T15:42:06Z

Added commit that removes "EMAC" from targets.json effectively disabling WiFi by default to avoid ethernet failures in automated tests.

c1728p9 · 2016-10-14T18:15:43Z

/morph test

bridadan · 2016-10-14T18:40:28Z

@bulislaw Thanks for that, this next test is just to ensure the build is ok.

/morph test

mbed-bot · 2016-10-14T19:35:52Z

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 0

All builds and test passed!

bridadan · 2016-10-14T19:42:32Z

Please ignore the X on the morph-test status, I accidentally triggered another build and canceled it. Test results LGTM 👍

0xc0170 force-pushed the ublox_drivers branch from 02088ca to fdf4e94 Compare October 11, 2016 13:58

bulislaw suggested changes Oct 11, 2016

View reviewed changes

sg- suggested changes Oct 11, 2016

View reviewed changes

sg- added the needs: work label Oct 11, 2016

andreaslarssonublox force-pushed the ublox_drivers branch from fdf4e94 to ec9113a Compare October 13, 2016 12:31

Added u-blox ODIN-W2 drivers for all toolchains

62bc686

andreaslarssonublox force-pushed the ublox_drivers branch from 4c3089b to 62bc686 Compare October 13, 2016 21:40

bulislaw approved these changes Oct 13, 2016

View reviewed changes

Added guard for DEVICE_EMAC in wifi_emac_api.cpp

394796f

Odin: Disable WiFi by default

e2c6b8d

Currently only one network interface can be compiled in at a given time, to avoid failing automated test on this target WiFi will be disabled by default.

c1728p9 added ready for merge and removed needs: work labels Oct 14, 2016

c1728p9 merged commit 7bcc63b into ARMmbed:master Oct 14, 2016

c1728p9 added release-version: 5.2.0-rc3 and removed ready for merge labels Oct 14, 2016

This was referenced Oct 17, 2016

[Exporters] Uvision5 project configuration missing Program Algorithm List #3049

Closed

[Exporters] Download of CMSIS packs #3051

Closed

andreaslarssonublox deleted the ublox_drivers branch November 23, 2016 10:23

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Ublox drivers #2977

Ublox drivers #2977

andreaslarssonublox commented Oct 11, 2016 •

edited

Loading

andreaslarssonublox commented Oct 11, 2016

0xc0170 commented Oct 11, 2016

bulislaw left a comment

bulislaw Oct 11, 2016

andreaslarssonublox Oct 11, 2016

bulislaw Oct 11, 2016

andreaslarssonublox Oct 11, 2016

sg- Oct 11, 2016

bulislaw Oct 13, 2016

sg- Oct 13, 2016

bulislaw Oct 13, 2016

sg- Oct 13, 2016

bulislaw Oct 13, 2016

sg- Oct 11, 2016 •

edited

Loading

bulislaw Oct 11, 2016

bulislaw commented Oct 13, 2016

bulislaw commented Oct 13, 2016

bulislaw commented Oct 13, 2016

andreaslarssonublox commented Oct 13, 2016 •

edited

Loading

andreaslarssonublox commented Oct 14, 2016

andreaslarssonublox commented Oct 14, 2016 •

edited

Loading

andreaslarssonublox commented Oct 14, 2016 •

edited

Loading

mbed-bot commented Oct 14, 2016

bulislaw commented Oct 14, 2016

c1728p9 commented Oct 14, 2016

bridadan commented Oct 14, 2016

mbed-bot commented Oct 14, 2016

bridadan commented Oct 14, 2016

		@@ -0,0 +1,193 @@
		/*---------------------------------------------------------------------------

Ublox drivers #2977

Ublox drivers #2977

Conversation

andreaslarssonublox commented Oct 11, 2016 • edited Loading

Description

Limitations

Status

Migrations

Related PRs

Todos

Deploy notes

Steps to test or reproduce

andreaslarssonublox commented Oct 11, 2016

0xc0170 commented Oct 11, 2016

bulislaw left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sg- Oct 11, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bulislaw commented Oct 13, 2016

bulislaw commented Oct 13, 2016

bulislaw commented Oct 13, 2016

andreaslarssonublox commented Oct 13, 2016 • edited Loading

andreaslarssonublox commented Oct 14, 2016

andreaslarssonublox commented Oct 14, 2016 • edited Loading

andreaslarssonublox commented Oct 14, 2016 • edited Loading

mbed-bot commented Oct 14, 2016

Output

bulislaw commented Oct 14, 2016

c1728p9 commented Oct 14, 2016

bridadan commented Oct 14, 2016

mbed-bot commented Oct 14, 2016

Output

bridadan commented Oct 14, 2016

andreaslarssonublox commented Oct 11, 2016 •

edited

Loading

sg- Oct 11, 2016 •

edited

Loading

andreaslarssonublox commented Oct 13, 2016 •

edited

Loading

andreaslarssonublox commented Oct 14, 2016 •

edited

Loading

andreaslarssonublox commented Oct 14, 2016 •

edited

Loading