-
Notifications
You must be signed in to change notification settings - Fork 3k
NRF52_DK support for IAR exporter #2985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As for device support, this is good to go. Tested locally.
/morph export-build |
Result: ABORTEDYour command has finished executing! Here's what you wrote!
|
uVision was hanging again, had to kill it. IAR made it through though. NRF52_DK and DELTA_DFBM_NQ620 both had failures similar to this:
Any ideas @sarahmarshy? |
@0xc0170 You were able to get this working locally? Did you have to do any extra steps? |
No extra steps. Tested with blinky, builds fine for me. This was this labeled ready for merge |
What version of IAR are you using? CI uses 7.40 |
Just tried it locally with IAR 7.70, looks like that was the issue. I'll need to update the CI machines to use this version. I'll try to do this tonight if at all possible and get another run in. |
/morph export-build |
Result: FAILUREYour command has finished executing! Here's what you wrote!
|
/morph export-build |
Result: FAILUREYour command has finished executing! Here's what you wrote!
|
What is for review here? What's outstanding? @bridadan Are those errors in the failure (iar build failures) known or new? |
@0xc0170 I'm trying to get the CI machines upgraded to IAR 7.70 for exporters so we don't lose the ability to run the exporter tests. I'm hoping I've got it all taken care of now, running again. /morph export-build |
Result: ABORTEDYour command has finished executing! Here's what you wrote!
|
Had to kill uvision because it was hanging, but IAR was all passing, so LGTM 👍 |
Adds support for nrf52_dk in IAR. Solves https://github.com/ARMmbed/oob-mbed-os-example-blinky/issues/4#issuecomment-252595498
@0xc0170