-
Notifications
You must be signed in to change notification settings - Fork 3k
lwip-interface: fix issue #2993 #2994
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@0xc0170 It fail to compile printing the following error:
As a note, |
97a2e94
to
2a7ba16
Compare
Thanks @pan- , I had old config in the example I was testing, cleaned and reproduced the issue. I rebased it, thus no inclusion required there. Please review again |
@0xc0170 It doesn't work, other parts of lwip (in my case |
2a7ba16
to
05a2b4d
Compare
/morph test |
I tried the HeartRate example with this patch on the K64F with the ST BLE shield and it worked. Are you seeing the same thing @pan- ? |
retest uvisor |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
Outputmbed Build Number: 0 All builds and test passed! |
@pan- Need your +1 for this one ! |
05a2b4d
to
142bfcc
Compare
DEVICE_ are passed as command line -D, thus no inclusion is required. ``platform.h`` is C++ header file, should not be pulled in C files
142bfcc
to
f8b682c
Compare
/morph test |
+1 now. |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
Outputmbed Build Number: 0 All builds and test passed! |
Description
Fix for the issue #2993, do not use
platform.h
in the C files.Status
READY
Tested defining EMAC for one platform and see if DEVICE_ it's properly defined and the code is compiled.
@pan-