Skip to content

NUCLEO_F303ZE: Enable all I2C instances #2999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 13, 2016

Conversation

jeromecoutant
Copy link
Collaborator

Description

A few sentences describing the overall goals of the pull request's commits.

Status

READY

OS2 and OS5 tests are still all OK

@bridadan
Copy link
Contributor

@jeromecoutant Can you provide some details on the potential consequence of this change? I see quite a few warning comments on the lines that were uncommented.

@jeromecoutant
Copy link
Collaborator Author

If user is using USB, he will not be able to use I2C2 and I2C3 instances (HW connection).
But if user doesn't use USB, he should be able to use multiple I2C instances.

@bridadan
Copy link
Contributor

Do we need to add any additional warnings to this target's page on the mbed site? Would this cause any existing applications to fail?

@sg- sg- added the needs: CI label Oct 12, 2016
@sg-
Copy link
Contributor

sg- commented Oct 12, 2016

/morph test

@sg-
Copy link
Contributor

sg- commented Oct 12, 2016

@mbed-bot: TEST

HOST_OSES=ALL
BUILD_TOOLCHAINS=ALL
TARGETS=ALL

@mbed-bot
Copy link

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 0

All builds and test passed!

@mbed-bot
Copy link

[Build 1032]
FAILURE: Something went wrong when building and testing.

@sg-
Copy link
Contributor

sg- commented Oct 13, 2016

Failure unrelated.

Scan: TARGET_NUMAKER_PFM_NUC472
Compile [  1.7%]: aes_alt.c
[Error] aes_alt.c@25,0:  #5: cannot open source input file "mbedtls/config.h": No such file or directory
"C:\Jenkins\workspace\mbed-2-build-library\targets\TARGET_NUVOTON\TARGET_NUC472\crypto\aes\aes_alt.c", line 25: Error:  #5: cannot open source input file "mbedtls/config.h": No such file or directory
C:\Jenkins\workspace\mbed-2-build-library\targets\TARGET_NUVOTON\TARGET_NUC472\crypto\aes\aes_alt.c: 0 warnings, 1 error

@sg- sg- merged commit 0ef0c61 into ARMmbed:master Oct 13, 2016
@jeromecoutant jeromecoutant deleted the PR_F303ZE_I2C branch October 14, 2016 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants