Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experimental fix for issue #29 #30

Merged
merged 3 commits into from
Aug 15, 2013
Merged

Experimental fix for issue #29 #30

merged 3 commits into from
Aug 15, 2013

Conversation

pbrier
Copy link
Contributor

@pbrier pbrier commented Aug 14, 2013

Experimental fix for Issue #29 "Network is not supported by GCC_ARM toolchain"
This adds the required RAM segment, the gnu++11 compiler flag (and a minor change to "libraries/tests/mbed/env/test_env.cpp" not to break compilation).

Network tests (Test 77...) are confirmed to work on original MBED device.

@@ -62,7 +62,7 @@ def __init__(self, target, options=None, notify=None, tool_path=""):
self.asm = [join(tool_path, "arm-none-eabi-as")] + self.cpu

self.cc = [join(tool_path, "arm-none-eabi-gcc"), "-std=gnu99"] + common_flags
self.cppc =[join(tool_path, "arm-none-eabi-g++"), "-std=gnu++98"] + common_flags
self.cppc =[join(tool_path, "arm-none-eabi-g++"), "-std=gnu++11"] + common_flags
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Peter,

Could you please explain why you neeed to switch to C++11? What part(s) of the code need this?

Thanks,
Bogdan

@adamgreen
Copy link
Contributor

I too bumped up my GNU ARM compiler to gnu++11 to get this line to compile:
https://github.com/mbedmicro/mbed/blob/master/libraries/net/lwip/Socket/UDPSocket.h#L25

In the past I have just removed this line from the header but recently I just switched my makefiles to use gnu++11 instead rather than requiring yet another modification to the sources in this repository. I have already made enough of those :)

@bogdanm
Copy link
Contributor

bogdanm commented Aug 15, 2013

I understand now, thank you. I'd rather remove that line than switching to C++11 for two main reasons:

  1. I don't fully understand the implications of switching to C++11, it might introduce (subtle) incompatibilities with our C++ code
  2. various GCC versions out there have various levels of support for C++11 (and this support is experimental AFAIK). Again, this might not affect us in any way, but I'd rather play it safe.

Thanks,
Bogdan

bogdanm added a commit that referenced this pull request Aug 15, 2013
Experimental fix for issue #29
@bogdanm bogdanm merged commit 370b270 into ARMmbed:master Aug 15, 2013
bridadan pushed a commit that referenced this pull request Jun 21, 2016
Update GCC toolchain to support the new format for the first line of …
pan- pushed a commit to pan-/mbed that referenced this pull request Apr 16, 2018
BLE: Add Gap privacy interfaces.
geky added a commit to geky/mbed that referenced this pull request Aug 25, 2018
sd-driver repository clean-up to follow common mbed-os component organisation
yossi2le pushed a commit to yossi2le/mbed-os that referenced this pull request Jan 2, 2019
Add NUCLEO_L476RG bootloader support config
linlingao pushed a commit to linlingao/mbed-os that referenced this pull request Jul 12, 2019
* GPIO port

* fixed hw_types

* delete TODO

* remove ARCM_BASE

* fixed naming issue

* possible fixed for LED3

* working GPIO

* GPIO is working

* add function for gpio_is_connected

* fixed PinMode bug
pan- pushed a commit to pan-/mbed that referenced this pull request May 29, 2020
Fix macros for compatibility with mbed classic
pan- added a commit to pan-/mbed that referenced this pull request May 29, 2020
Remove section on 'Porting your BLE app from mbed Classic to mbed OS'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants