Fixups to network code after recent merges. #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Peter's and my changes to LPC1768.ld ended up adding the same AHBSRAM0 and AHBSRAM1 section clauses to the script twice. I removed one copy. I also pulled Peter's define of the ETHMEM_SECTION macro up into the previous nested #if so that the preprocessor wouldn't spit out a redefined macro warning. I verified that building the code clean before and after these changes still results in the same .bin file but now without warnings and/or duplicate code.
bogdanm
added a commit
that referenced
this pull request
Aug 15, 2013
Fixups to network code after recent merges.
|
Thanks yet again! |
|
Actually, I should be the thanking you. I haven't noticed the double definition in LPC1768.ld, so thank you! |
SeppoTakalo
pushed a commit
that referenced
this pull request
Nov 9, 2016
Flag function mbedtls_ssl_conf_dtls_cookies with MBEDTLS_SSL_SRV_C to enable SSL server disabling that can save flash ~3,2kB.
pan-
pushed a commit
to pan-/mbed
that referenced
this pull request
Apr 20, 2018
BLE: Handle new addresses type in GenericGap.
geky
pushed a commit
to geky/mbed
that referenced
this pull request
Aug 25, 2018
Small consistency changes to frequency function
linlingao
pushed a commit
to linlingao/mbed-os
that referenced
this pull request
Jul 12, 2019
Add Port API stubs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Peter's and my changes to LPC1768.ld ended up adding the same AHBSRAM0
and AHBSRAM1 section clauses to the script twice. I removed one copy.
I also pulled Peter's define of the ETHMEM_SECTION macro up into the
previous nested #if so that the preprocessor wouldn't spit out a
redefined macro warning.
I verified that building the code clean before and after these changes
still results in the same .bin file but now without warnings and/or
duplicate code.