[NRF5] Bootloader for NRF52_DK @s132 and NRF51_DK @s130 #3376

nvlsianpu · 2016-12-06T15:31:37Z

either single and dual banks bootloaders for nRF51 and nRF52 (complied to *.hex) @s13x 2.0.0
new NRF51_DK_BOOT, NRF52_DK_BOOT, NRF51_DK_OTA, NRF52_DK_OTA targets for SoftDevice 13x
add support for choice bootloader from a list of a few.

Reserve BLE dfu service for nrf5x (previously was for nrf51)

Legacy bootloader's targets (@s110) NRF51_DK_OTA and NRF51_DK_BOOT are renamed to NRF51_DK_LEGACY_OTA and NRF51_DK_LEGACY_BOOT

For support choosing of a bootloader for a target (for now dual bank or single bank solution) the value target.bootloader_select_index was added to target descriptions.
This could be override in a child target or in a application configuration file in order to make a another choice.

+ either single and dual banks bootloaders for nRF51 and nRF52 (complided to *.hex) + new NRF51_DK_BOOT, NRF52_DK_BOOT, NRF51_DK_OTA, NRF52_DK_OTA for SoftDevice 13x + add support for choice bootloader from a list of a few. Reserve BLE dfu service for nrf5x (previously was for nrf51)

nvlsianpu · 2016-12-06T15:38:34Z

@pan- @anangl: Need your opinions.

nvlsianpu · 2016-12-08T07:31:36Z

For curious: code with modification of used nrf5 bootloader https://github.com/nvlsianpu/nrf5_bootloader based on nRF5 sdk 11.

Be aware of https://infocenter.nordicsemi.com/index.jsp?topic=%2Fcom.nordic.infocenter.sdk5.v11.0.0%2Fbledfu_bootloader_introduction.html Probably you will need to creating a zip with image and init packet.

nvlsianpu · 2016-12-08T09:33:54Z

targets/TARGET_NORDIC/TARGET_NRF5/sdk/libraries/bootloader_dfu/bootloader_util.c

+    SysTick->CTRL  = 0;
+#endif    
+    // disable all interrupts
+    core_util_critical_section_enter();


line TBR - already handled here https://github.com/nvlsianpu/mbed/blob/nrf5_dfu_s13x_v2/targets/TARGET_NORDIC/TARGET_NRF5/sdk/libraries/bootloader_dfu/dfu_app_handler.c#L179

pan-

Overall, I'm happy with this PR (I need to test it) but I believe that it would be very helpful to link to Nordic documentation (here) and explain on the mbed Nordic page how to switch from single bank to dual bank.

I also wonder if it is possible to add size constraint in the linker script file when dual bank is used or at least explain step by step what has to be done.

It would also be nice to explain to users how to generate a new bootloader (outside this PR).

pan- · 2016-12-08T11:45:50Z

targets/targets.json

@@ -2387,11 +2387,12 @@
        "MERGE_SOFT_DEVICE": true,
        "EXPECTED_SOFTDEVICES_WITH_OFFSETS": [
            {
-                "boot": "",
+                "boot": ["s130_nrf51_2.0.0_sb_bootloader.hex", "s130_nrf51_2.0.0_sb_bootloader.hex"],


Why the single bank binary is referenced twice ?

pan- · 2016-12-08T11:47:13Z

targets/targets.json

        "EXPECTED_SOFTDEVICES_WITH_OFFSETS": [
            {
-                "boot": "",
+                "boot": ["s132_nrf52_2.0.0_db_bootloader.hex", "s132_nrf52_2.0.0_sb_bootloader.hex"],


There is a typo in the dual bank bootloader name: s132_nrf52_2.0.0_db_bootloadre.hex instead of s132_nrf52_2.0.0_db_bootloader.hex

nvlsianpu · 2016-12-08T13:32:54Z

I believe that it would be very helpful to link to Nordic documentation (here) and explain on the mbed Nordic page how to switch from single bank to dual bank.

It would also be nice to explain to users how to generate a new bootloader (outside this PR).

I agree. I will update/create FOTA target web immediately after we done this PR

I also wonder if it is possible to add size constraint in the linker script file when dual bank is used or at least explain step by step what has to be done.

for now I planned to emphasize this in documentation - although I think it's very good idea. But due the time constrains I must wait for a spare time.

…n 9instead of two single bank bootloaders) fix: typo in dual bank bootloader intel-hex file name fix: remove redundant interupts disabling on bootloader startup call

bridadan · 2016-12-08T18:38:44Z

Maintainers: when running tests, please run a nightly on this since the softdevice will affect all of the tests.

adbridge · 2016-12-12T16:20:58Z

@nvlsianpu Do you believe this is ready now? All actions done?

bridadan · 2016-12-12T20:18:12Z

/morph test-nightly

mbed-bot · 2016-12-13T00:28:26Z

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test-nightly

Output

mbed Build Number: 1258

All builds and test passed!

nvlsianpu · 2016-12-13T07:56:29Z

It's ready to be merged. As changed are approved I'm going to update DK documentation.

nvlsianpu · 2016-12-15T13:01:28Z

FYI:
Documentation for this features aimed to github is here https://github.com/nvlsianpu/mbed/blob/nrf5_doc/targets/TARGET_NORDIC/ReadMe.md. It's only waiting for nordic's tech writer for a vertification.

sg- · 2016-12-15T16:24:22Z

This will require an alignment with online tools deployment. @theotherjimmy @screamerbg need to sync about when it will be possible.

@pan- Did you test this?

adbridge · 2016-12-19T17:21:22Z

@pan- bump

pan- · 2016-12-22T11:42:47Z

@sg- I've tested this, the content of the PR works but it is not that simple to get it working.
The old DFU service in BLE API is not perfectly aligned with the latest Nordic DFU flow and require a bit of work.

I would prefer to have this PR integrated in a feature branch rather than in master so the missing items needed to have a good DFU feature like a refresh of the update services and a good documentation will be completed before the integration into master.

sg- · 2016-12-22T14:29:23Z

Thanks for the feedback @pan-

@nvlsianpu Can you change this PR to be against https://github.com/ARMmbed/mbed-os/tree/feature-nrf5_dfu_s13x_v2

janjongboom · 2017-08-02T14:56:13Z

@pan- @sg- Why has this never made it into master? I've been using the _OTA target and it works fine.

nvlsianpu mentioned this pull request Dec 6, 2016

Feature request: DFU #3363

Closed

0xc0170 added the needs: review label Dec 7, 2016

nvlsianpu commented Dec 8, 2016

View reviewed changes

pan- reviewed Dec 8, 2016

View reviewed changes

fix: dual and single bank bootloaders in MCU_NRF52 teraget descriptio…

8e641c3

…n 9instead of two single bank bootloaders) fix: typo in dual bank bootloader intel-hex file name fix: remove redundant interupts disabling on bootloader startup call

pan- mentioned this pull request Dec 12, 2016

Documentation request - soft device / bootloader ? ARMmbed/mbed-cli#393

Closed

0xc0170 approved these changes Dec 13, 2016

View reviewed changes

0xc0170 added ready for merge and removed needs: review labels Dec 13, 2016

nvlsianpu mentioned this pull request Dec 16, 2016

[NRF5] documnetation - readme file for nRF5x bases targets #3453

Merged

0xc0170 added needs: review and removed ready for merge labels Dec 21, 2016

nvlsianpu changed the base branch from master to feature-nrf5_dfu_s13x_v2 December 22, 2016 15:07

0xc0170 removed the needs: review label Dec 23, 2016

0xc0170 merged commit 15d1944 into ARMmbed:feature-nrf5_dfu_s13x_v2 Dec 23, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[NRF5] Bootloader for NRF52_DK @s132 and NRF51_DK @s130 #3376

[NRF5] Bootloader for NRF52_DK @s132 and NRF51_DK @s130 #3376

nvlsianpu commented Dec 6, 2016 •

edited

Loading

nvlsianpu commented Dec 6, 2016

nvlsianpu commented Dec 8, 2016

nvlsianpu Dec 8, 2016

pan- left a comment

pan- Dec 8, 2016

nvlsianpu Dec 8, 2016

pan- Dec 8, 2016

nvlsianpu Dec 8, 2016

nvlsianpu commented Dec 8, 2016

bridadan commented Dec 8, 2016

adbridge commented Dec 12, 2016

bridadan commented Dec 12, 2016

mbed-bot commented Dec 13, 2016

nvlsianpu commented Dec 13, 2016

nvlsianpu commented Dec 15, 2016

sg- commented Dec 15, 2016

adbridge commented Dec 19, 2016 •

edited by sg-

Loading

pan- commented Dec 22, 2016

sg- commented Dec 22, 2016

janjongboom commented Aug 2, 2017

[NRF5] Bootloader for NRF52_DK @s132 and NRF51_DK @s130 #3376

[NRF5] Bootloader for NRF52_DK @s132 and NRF51_DK @s130 #3376

Conversation

nvlsianpu commented Dec 6, 2016 • edited Loading

nvlsianpu commented Dec 6, 2016

nvlsianpu commented Dec 8, 2016

nvlsianpu Dec 8, 2016

Choose a reason for hiding this comment

pan- left a comment

Choose a reason for hiding this comment

pan- Dec 8, 2016

Choose a reason for hiding this comment

nvlsianpu Dec 8, 2016

Choose a reason for hiding this comment

pan- Dec 8, 2016

Choose a reason for hiding this comment

nvlsianpu Dec 8, 2016

Choose a reason for hiding this comment

nvlsianpu commented Dec 8, 2016

bridadan commented Dec 8, 2016

adbridge commented Dec 12, 2016

bridadan commented Dec 12, 2016

mbed-bot commented Dec 13, 2016

Result: SUCCESS

Output

nvlsianpu commented Dec 13, 2016

nvlsianpu commented Dec 15, 2016

sg- commented Dec 15, 2016

adbridge commented Dec 19, 2016 • edited by sg- Loading

pan- commented Dec 22, 2016

sg- commented Dec 22, 2016

janjongboom commented Aug 2, 2017

nvlsianpu commented Dec 6, 2016 •

edited

Loading

adbridge commented Dec 19, 2016 •

edited by sg-

Loading