Add support for remote CAN frames on LPC11CXX #346
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed bug where outgoing messages always had DIR bit set, even if message type was CANRemote. Fixed TODO where incoming messages were always assigned message type CANData even if the message was remote Changed filter setup to no longer set MDIR bit in receive filter; this allows remote messages to pass through the filter.
bogdanm
added a commit
that referenced
this pull request
Jun 11, 2014
Add support for remote CAN frames on LPC11CXX
ccli8
pushed a commit
to ccli8/mbed-os
that referenced
this pull request
Sep 19, 2024
* STM32H7: Fix wrong address for DTCM in linker script * Fix tab
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DIRbit set, even if message type wasCANRemote.CANDataeven if the message was remoteMDIRbit in receive filter; this allows remote messages to pass through the filter.I've tested this on an LPC11C14 and seems to work fine. The one caveat is that the filter no longer prevents remote messages from showing up in
CAN.read()(though the message type is now set correctly). I'm not sure what the default behavior for filtering data vs remote frames on other platforms is right now.Perhaps the filter API should include an enum for filtering message of type CANData vs CANRemote vs either.