Ignore build directory from scan resources #3852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can't we have build for as param to scan resources and defaulting to None if not specified? This will make it backwards compatible and also won't throw nasty python error if build dir is not assigned before scan resources |
|
Build dir is assigned in the constructor |
Does that answer your question @screamerbg ? |
|
Hey @0xc0170 New implementation coming soon. |
theotherjimmy
force-pushed
the
ignore-build-dir
branch
5 times, most recently
from
c17aea5
to
36736cf
Compare
|
@screamerbg Could you review again? |
theotherjimmy
force-pushed
the
ignore-build-dir
branch
4 times, most recently
from
2997deb
to
326a0e4
Compare
This is a bug fix for the following bug (Github issue ARMmbed#437): If two builds were run specifying a non-default build folder, the second build would fail to link with duplicate symbols and may not fit on the device. The root of this problem is that these non-default build folders are not ignored by scan-resources, and therefore included in the build. We fix this bug by ignoring the build directory passed into the tools.
theotherjimmy
force-pushed
the
ignore-build-dir
branch
from
326a0e4
to
fbb6f71
Compare
The prior patch in this series makes the assumption that any building will go through `build_api.prepare_toolchain`. This was not a valid assumption for the mbed2 build process. So, instead of maintaining 2 ways of using the toolchain classes, I elected to unify on `prepare_toolchain`.
An earlier patch in this series relies on the assumption that all toolchain construction goes through `prepare_toolchain`. This is still not the case. The only remaining user of the `mbedToolchain` object that does not go through `prepare_toolchain` is the static analysis scanner. It's basically dead-code at this point. I say we remove it. So this patch removes it.
An earlier patch in this series changed the API for `build_api.prepare_toolchain`. This commit updates the `find_test` function to call `prepare_toolchain` correctly.
|
This snowballed pretty good. |
screamerbg
approved these changes
Mar 7, 2017
|
/morph test |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
0xc0170
added
ready for merge
release-version: 5.4.1
and removed
needs: review
ready for merge
labels
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bug fix for the following bug (Github issue ARMmbed/mbed-cli#437):
If two builds were run specifying a non-default build folder, the second
build would fail to link with duplicate symbols and may not fit on the
device. The root of this problem is that these non-default build folders
are not ignored by scan-resources, and therefore included in the build.
We fix this bug by ignoring the build directory passed into the tools.