Add the FPU field to the <Cpu> tag in Keil #3861
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recently the Keil IDE has released version 5.23. This version requires the FPU to be set as part of the <Cpu> tag in the .uvprojx (XML project file). This patch adds the appropriate FPU settings based on the trailing F (FPU enabled) or FD (Double precesion FPU enabled) string of the core.
theotherjimmy
changed the title
Contributor
Author
|
@bridadan Can we upgrade the CI machines to use version 5.23 of uVision and run a morph export-build? |
Contributor
bridadan
approved these changes
Mar 1, 2017
Contributor
Author
|
/morph export-build |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
Outputmbed Build Number: 130 All exports and builds passed! |
Contributor
Author
|
looks backwards compatible. Let's get this in. |
Contributor
|
retest uvisor |
0xc0170
approved these changes
Mar 2, 2017
Contributor
0xc0170
left a comment
0xc0170
left a comment
There was a problem hiding this comment.
Tested locally with 5.22 , this resolves the issues I have seen.
Contributor
Anyone tested this with earlier uvision than 5.22/23 ? |
Contributor
|
The CI machines test version 5.21 😄 |
0xc0170
added
release-version: 5.4.0-rc2
and removed
ready for merge
release-version: 5.4.0
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently Keil released version 5.23 of their IDE. This version requires
the FPU to be set as part of the tag in the .uvprojx (XML project
file). This patch adds the appropriate FPU settings based on the
trailing F (FPU enabled) or FD (Double precesion FPU enabled) string of
the core.
Related issues: