Skip to content

NCS36510: Default range changed from 0 to 950mV - ADC #3869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 14, 2017
Merged

NCS36510: Default range changed from 0 to 950mV - ADC #3869

merged 3 commits into from
Mar 14, 2017

Conversation

radhika-raghavendran
Copy link
Contributor

@radhika-raghavendran radhika-raghavendran commented Mar 2, 2017 •
edited
Loading

now the range is 0 to 3.3V

Notes:

  • Pull requests will not be accepted until the submitter has agreed to the contributer agreement.
  • This is just a template, so feel free to use/remove the unnecessary things

Description

The default range of ADC was 0 to 950mV. Now it has been changed to 0 to 3.3V.

Status

Migrations

If this PR changes any APIs or behaviors, give a short description of what API users should do when this PR is merged.

YES | NO

Related PRs

List related PRs against other branches:

branch PR
other_pr_production link
other_pr_master link

Todos

  • Tests
  • Documentation

Deploy notes

Notes regarding the deployment of this PR. These should note any
required changes in the build environment, tools, compilers, etc.

Steps to test or reproduce

Attached are the green tea test results
ARM_Results-02-03-2017.txt

@radhika-raghavendran radhika-raghavendran changed the title Default range changed from 0 to 950mV - ADC NCS36510: Default range changed from 0 to 950mV - ADC Mar 2, 2017
@0xc0170
Copy link
Contributor

0xc0170 commented Mar 6, 2017

Any test run, like ci test shield to exercise ADC ?

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 6, 2017

/morph test

@mbed-bot
Copy link

mbed-bot commented Mar 6, 2017

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1643

All builds and test passed!

@radhika-raghavendran
Copy link
Contributor Author

Adding the definitions for A4 and A5 ADC pins.
They are not connected on the NCS36510 board; defined as NC in the file PinNames.h

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 9, 2017

Please once again rebase (that should remove all those commits from this PR that are already on master)

@radhika-raghavendran
Copy link
Contributor Author

I have rebased and picked only the latest change.
Can you please verify and let me know if it is ok?

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 9, 2017

Can you please verify and let me know if it is ok?

Rebase looks good but I dont see previous change for ADC. Only pins NC for A4/A5 (they are unaligned in the file). Why adc changes were removed?

@radhika-raghavendran
Copy link
Contributor Author

@0xc0170 The previous change was lost during the rebase and cherry pick. I have redone the change.
I hope it works this time :)

0xc0170
0xc0170 reviewed Mar 10, 2017
View reviewed changes
targets/TARGET_ONSEMI/TARGET_NCS36510/PinNames.h Outdated
@@ -59,6 +60,8 @@ typedef enum {
A1,
A2,
A3,
A4 = NC,
Copy link
Contributor

@0xc0170 0xc0170 Mar 10, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: used tabs as its misaligned? Can you fix it?

0xc0170
0xc0170 approved these changes Mar 10, 2017
View reviewed changes
Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (just that one style misalignment)

@radhika-raghavendran
Copy link
Contributor Author

@0xc0170 Changed the misaligned style.

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 10, 2017

/morph test

@mbed-bot
Copy link

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1671

All builds and test passed!

@adbridge adbridge merged commit 538e160 into ARMmbed:master Mar 14, 2017
aisair pushed a commit to aisair/mbed that referenced this pull request Apr 30, 2024
Release 139 of the mbed library
f1d5495 
Ports for Upcoming Targets

3934: [Silicon Labs] Update to HAL and devices ARMmbed/mbed-os#3934

Known Issues

There is an issue with LPC1768 failing the 'Semihost file system' test with this release.

Fixes and Changes

3691: [TLS / hw acceleration] AES ECB for NUCLEO_F439ZI ARMmbed/mbed-os#3691
3869: NCS36510: Default range changed from 0 to 950mV - ADC  ARMmbed/mbed-os#3869
3893: [STM32F7] Update STM32 Cube version v1.6.0 ARMmbed/mbed-os#3893
3917: Fix  mistake register setting in serial_format() ARMmbed/mbed-os#3917
3927: [DELTA_DFBM_NQ620] Add RC calibration setting and revise mbed_overrides.c ARMmbed/mbed-os#3927
3918: [NUC472/M453] Support unique locally administered MAC address and other driver updates ARMmbed/mbed-os#3918
3920: Heap size adjusted to work for both tls-client and mbed-client ARMmbed/mbed-os#3920
3969: NUCLEO_F302R8: Add missing PB_8/PB_9 CAN pins ARMmbed/mbed-os#3969
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

Assignees
No one assigned
Labels
release-version: 5.4.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@radhika-raghavendran @0xc0170 @mbed-bot @adbridge